fix(analytics/ prototype): detect in-flight auctions as missed, remove bidWon#293
Merged
mosherBT merged 1 commit intoMay 27, 2026
Merged
Conversation
… bidWon tracking Auctions that fired auctionInit before our hook was set but whose auctionEnd arrives after are now correctly marked as missed. Previously only fully-completed past auctions were caught. Also removes bidWon event tracking which is no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mosherBT
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auctionInitbefore our analytics hook was set, but whoseauctionEndarrives after, are now correctly marked asmissed=true. Previously only fully-completed past auctions (bothauctionInitandauctionEndingetEvents()) were caught.bidWontracking: thetrackBidWonmethod and allbidWonevent listeners (replay + live) are removed — no longer needed.How it works
auctionInitIDs intomissedAuctionIds, then when anauctionEndis encountered, remove from set and process as missed.missedAuctionIdsafter replay are auctions that started but haven't ended yet (in-flight).auctionEndlistener checksmissedAuctionIds— if the auction ID is present, it's an in-flight auction we missed, so it's markedmissed=trueand removed from the set.Test plan
missed=truein witness payloadmissed=falsebid_wonwitness events are emitted🤖 Generated with Claude Code