Skip to content

feature: Add KB entry for PII leaked in network traffic#294

Draft
Nouri-Anouar wants to merge 1 commit into
masterfrom
feature/pii-leaked-network-traffic-kb
Draft

feature: Add KB entry for PII leaked in network traffic#294
Nouri-Anouar wants to merge 1 commit into
masterfrom
feature/pii-leaked-network-traffic-kb

Conversation

@Nouri-Anouar

Copy link
Copy Markdown

Summary

  • Existing LEAKING_PERSONAL_INFORMATION entry only covers PII found in local files/logs.
  • Adds a sibling entry, LEAKING_PERSONAL_INFORMATION_REQUEST, scoped to PII detected in HTTP request/response traffic — same pattern as LEAKING_CREDENTIALS_LOGS / LEAKING_CREDENTIALS_REQUEST.
  • To be consumed by agent_sensitive_info_detector once it's extended to scan network traffic.

Test plan

  • pytest tests/kb_test.py structural checks pass (json validity, unique folder/title names, valid category codes)

Existing LEAKING_PERSONAL_INFORMATION entry only covers PII found in
local files/logs. This adds a sibling entry scoped to PII detected in
HTTP request/response traffic, following the same pattern as
LEAKING_CREDENTIALS_LOGS / LEAKING_CREDENTIALS_REQUEST.
@Nouri-Anouar Nouri-Anouar changed the title Add KB entry for PII leaked in network traffic feature: Add KB entry for PII leaked in network traffic Jul 9, 2026
@Nouri-Anouar Nouri-Anouar marked this pull request as draft July 9, 2026 18:31

@ostorlab-ai-pr-review ostorlab-ai-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Total Issues Found: 1
Critical Issues: 0
Suggestions: 1

Key Findings:
The review identified a minor grammatical issue in a metadata JSON file. Specifically, the word "Information" is an uncountable noun and should be paired with the singular verb "was" instead of "were".

Overall Assessment:
The overall code quality is good. The only findings are minor grammatical inconsistencies in text strings, which do not impact functionality.

Recommendations:

  • Update the phrasing in the LEAKING_PERSONAL_INFORMATION_REQUEST meta.json file to use correct grammar.
  • Address the same grammatical issue in the existing LEAKING_PERSONAL_INFORMATION entry in a follow-up task to ensure consistency across the codebase.

@@ -0,0 +1,53 @@
{
"risk_rating": "medium",
"short_description": "Personally Identifiable Information were detected leaked in network traffic.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Information" is an uncountable noun and takes the singular verb "was". Consider changing to: "Personally Identifiable Information was detected leaked in network traffic." or rephrasing to "Personally Identifiable Information (PII) was detected in network traffic."

Note: The existing LEAKING_PERSONAL_INFORMATION entry has the same grammar issue ("were detected"). It would be good to fix both in a follow-up.

Suggested change
"short_description": "Personally Identifiable Information were detected leaked in network traffic.",
"short_description": "Personally Identifiable Information was detected leaked in network traffic.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant