Conversation
…list vavoo_config.createSetup() has no exception handling anywhere, and the widget only gets self["config"].l.setList(self.list) once, at the very end of the method. If any single getConfigListEntry(...) call raised - these touch Enigma2 core config widgets (ConfigSelectionNumber, ConfigClock) outside this repo, whose behavior can differ by image/ build, same class of issue as this session's wraparound-navigation fix - the whole rebuild silently aborted with no visible error, freezing the screen on whatever it displayed before. Confirmed via user report: "Scheduled List" -> "Schedule type" showed correctly after enabling automatic bouquet updates, but "Update interval (minutes)" right after it never appeared, on one user's image while working fine on another's - consistent with an exception at that specific entry silently cutting off everything from that point on, rather than the option having been removed. Wraps each of the three schedule-related entries (Schedule type, Update interval, Time to start update) in its own try/except, so a failure building one entry no longer prevents the rest of the list - including everything listed after it (Link in Main Menu, stats, debug logging) - from being built and shown. Doesn't fix whatever the underlying per-image config widget issue is (not reproducible in this sandbox - no live Enigma2 environment), but stops it from taking the rest of the screen down with it, and the print() gives a real error to look at next time this happens.
AutoStartTimer._update_bouquets() (the scheduled job this section controls) does "Rytec matching, EPG feed downloads, and bouquet file I/O" as one combined cycle per its own comment - but every label here said "Bouquet Update", with no mention of EPG anywhere. This is the only place in the plugin that controls how often EPG gets refreshed in the background, and a user looking for an "EPG update timer" had no way to recognize this section as being it. Relabeled "Scheduled List"/"Update interval (minutes)"/"Time to start update" and their help text to say EPG/Bouquet explicitly. No behavior change - purely making the existing control findable for what it actually does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config screen: don't let one bad entry silently kill the rest of the list.
vavoo_config.createSetup()had no exception handling anywhere, and only committed the rebuilt list to the widget once, at the very end. If any singlegetConfigListEntry(...)call raised - these touch Enigma2 core config widgets (ConfigSelectionNumber,ConfigClock) outside this repo, whose behavior can differ by image/build - the whole rebuild silently aborted with no visible error, freezing the screen on whatever it displayed before. Confirmed via a user report: "Schedule type" showed correctly after enabling scheduled updates, but "Update interval (minutes)" right after it never appeared, on one image while working fine on another - consistent with an exception at that entry silently cutting off everything after it. Now each of the three schedule-related entries is wrapped in its own try/except, so a failure building one no longer takes the rest of the screen down with it.Relabel the scheduled update section to mention EPG, not just bouquets.
AutoStartTimer._update_bouquets()(the job this section controls) does Rytec matching, EPG feed downloads, and bouquet file I/O as one combined cycle - but every label said "Bouquet Update" with no mention of EPG anywhere, so it wasn't recognizable as the plugin's only EPG-refresh-interval control. Relabeled "Scheduled List" / "Update interval (minutes)" / "Time to start update" and their help text to say EPG/Bouquet explicitly. No behavior change - purely making the existing control findable for what it actually does.