Seed all pecos-neo test simulators and enforce determinism with a source scan - #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #454, implementing the prevention decided after the
test_multiple_shotsflake: pecos-neo test code is now deterministic by construction, and a scan enforces it.SparseStab, 10StateVec, 2StateVecEngine), acrosstests/and every#[cfg(test)]module. Runtime code and doc examples are untouched; no new APIs were needed.tests/determinism_discipline.rs: scans the crate's own sources (tests/entirely, plus#[cfg(test)]regions insrc/, including externalmod tests;files) and fails on any entropy-seeded simulator constructor, with an empty allowlist and a message naming the file, line, and seeded alternative. Non-vacuity assertions prove the scan reads real code.SparseStab::new(in either atests/file or a#[cfg(test)]module fails the scan naming the site.Context recorded in #332: the canonical RNG platform should eventually make whole-run determinism single-knob; this PR makes the test suite deterministic today without preempting that design.