Skip to content

MACE interface, vol. 2#242

Open
danielhollas wants to merge 32 commits into
masterfrom
dh-mace
Open

MACE interface, vol. 2#242
danielhollas wants to merge 32 commits into
masterfrom
dh-mace

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

@danielhollas danielhollas commented May 30, 2026

This is a continuation from #224, with the following changes

  • Fix coordinates received from ABIN (without this the interface was simply not working)
  • Use MACECalculator instead of calling pytorch directly
  • Fix float32 evaluation
  • removed install_mace.sh and the MACE-OFF model file

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 68.18182% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.64%. Comparing base (5bac5b2) to head (022ad76).

Files with missing lines Patch % Lines
src/mace_mpi_api.F90 68.90% 26 Missing and 11 partials ⚠️
src/force_mace.F90 60.97% 10 Missing and 6 partials ⚠️
src/init.F90 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   84.02%   83.64%   -0.39%     
==========================================
  Files          47       49       +2     
  Lines        6617     6791     +174     
  Branches      766      790      +24     
==========================================
+ Hits         5560     5680     +120     
- Misses        858      894      +36     
- Partials      199      217      +18     
Flag Coverage Δ
unittests 18.26% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/forces.F90 91.12% <100.00%> (+0.07%) ⬆️
src/mpi_wrapper.F90 70.51% <ø> (+1.76%) ⬆️
src/init.F90 82.56% <80.00%> (-0.07%) ⬇️
src/force_mace.F90 60.97% <60.97%> (ø)
src/mace_mpi_api.F90 68.90% <68.90%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants