Skip to content

Vb/hwc 3.8.1 - #287

Merged
snehar-nd merged 36 commits into
release-3.9.0from
vb/hwc-3.8.1
Aug 27, 2026
Merged

Vb/hwc 3.8.1#287
snehar-nd merged 36 commits into
release-3.9.0from
vb/hwc-3.8.1

Conversation

@snehar-nd

Copy link
Copy Markdown
Contributor

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

snehar-nd and others added 30 commits March 25, 2026 10:49
AMM-2127 clinical observation search is not working.
…ronments and fix past-obsteric vanID

- All environment files updated to call /getUserFacilityDetails
- past-obsteric-history: vanID to facilityID

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… 104 worklist

- inventory.service.ts: vanID to facilityID in redirect URL
- lab workarea: techForm vanID to facilityID
- 104 referred worklist: vanID to facilityID
- environment files: getWorklistByVanID to getWorklistByFacilityID

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…component

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…session fallback

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t from session

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add getBenFamilyDetailsUrl to all environment files pointing to
  identity-api/family/getBenFamilyDetails
- Add getBenFamilyDetailsByBenRegId() service method in FamilyTaggingService
- Simplify getBeneficiaryDetailsAfterFamilyTag() in FamilyTaggingDetailsComponent
  to call the new endpoint directly with beneficiaryRegId instead of doing a
  two-step identityQuickSearch + getFamilyDetails lookup

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: moved latest fix of common ui
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ocation pre-fill

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…facilityID tracing

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- sendToNurseWindow (3 sites): include facilityID in benObject so
  i_ben_flow_outreach is created with facilityID — without this
  HWC patients are invisible in nurse worklist
- sendBenToAmrit: fix missing JSON.parse on serviceLineDetails
  and add facilityID to ABHA registration flow

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix the Issue in linking Care Context
InventoryService.current_language_set was declared but never
assigned, so the guard's error-alert branch threw instead of
showing a message whenever authKey/facility/host was missing —
masking the real problem and making the redirect look like a
no-op. Populate it from HttpServiceService.currentLangugae$, the
same pattern AuthGuard already uses.

Also guard getppID() against a missing serviceLineDetails entry
(JSON.parse(null).parkingPlaceID threw before the redirect could
fire), and fix the setLanguage fallback check in worklist.component
(sessionStorage.getItem returns null, never undefined).
Sneha and others added 5 commits August 4, 2026 12:12
InventoryService.current_language_set was declared but never
assigned, so the guard's error-alert branch threw instead of
showing a message whenever authKey/facility/host was missing —
masking the real problem and making the redirect look like a
no-op. Populate it from HttpServiceService.currentLangugae$, the
same pattern AuthGuard already uses.

Also guard getppID() against a missing serviceLineDetails entry
(JSON.parse(null).parkingPlaceID threw before the redirect could
fire), and fix the setLanguage fallback check in worklist.component
(sessionStorage.getItem returns null, never undefined).
…ct-3.8.1

fix(pharmacist): stop silent failure when redirecting to Inventory
…sis autocomplete

The panel-fill bootstrap logic proactively fetched extra pages whenever the
dropdown didn't scroll, flipping noMore to true almost immediately. Now
"End of results" only shows when a real fetch (initial search or
scroll-triggered page) actually returns an empty response.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-context popup (#286)

After a beneficiary returns from the lab and the doctor clicks Update,
getHealthIDDetails() concatenated res.data.response directly into the
popup text. When that field was falsy, `undefined + '. '` rendered the
literal word "undefined" in the success dialog. Fall back to a proper
success string, matching the pattern already used by the initial Save flow.

Co-authored-by: Sneha <sneha@ADMINs-MacBook-Pro.local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ffc7c4e-c8ae-4895-885a-1c8c23f2ed6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Resolves the package-lock.json conflict in PR #287. package.json merged
cleanly on its own, keeping each side's intended change:

- @angular/material-moment-adapter ^16.2.12 and ngx-bootstrap ^11.0.0
  (vb/hwc-3.8.1's deliberate downgrades for Angular 16 compatibility)
- jasmine-core ~5.12.0 (release-3.9.0's dependabot bump)

package-lock.json was regenerated from the merged package.json with
`npm install --package-lock-only --lockfile-version 2` rather than
hand-resolved, so the tree is internally consistent. lockfileVersion 2
is preserved to match both sides; resolved versions are jasmine-core
5.12.1, material-moment-adapter 16.2.14, ngx-bootstrap 11.0.2.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
18.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@snehar-nd
snehar-nd merged commit ccfdec3 into release-3.9.0 Aug 27, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants