Skip to content

Remove defaults when creating ismrmrd header - #100

Open
ckolbPTB wants to merge 1 commit into
PTB-MR:mainfrom
ckolbPTB:improve_raw_header
Open

Remove defaults when creating ismrmrd header#100
ckolbPTB wants to merge 1 commit into
PTB-MR:mainfrom
ckolbPTB:improve_raw_header

Conversation

@ckolbPTB

@ckolbPTB ckolbPTB commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The input parameters to create_header have default values already. There is no need to define the parameters again with their default values.

@ckolbPTB
ckolbPTB requested a review from schuenke August 14, 2026 14:17
@ckolbPTB ckolbPTB changed the title Remove defaults from ismrmrd header Remove defaults when creating ismrmrd header Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/.local/lib/python3.12/site-packages/mrseq
   _version.py770%2–9
/home/runner/.local/lib/python3.12/site-packages/mrseq/preparations
   t2_prep.py51198%195
/home/runner/.local/lib/python3.12/site-packages/mrseq/sequences
   epi2d_fid.py128993%255, 358, 415–420, 432, 438
   epi2d_se.py1481292%204–206, 316, 419, 476–481, 493, 499
   grpe_flash_dixon.py2051891%121, 124, 189, 206–208, 329, 348, 399, 409, 511, 579–584, 596, 602
   radial_flash.py1401192%101, 104, 258, 352, 410–415, 427, 433
   spiral_flash.py1201092%95, 230, 319, 369–374, 386, 392
   t1_inv_rec_gre_single_line.py93990%162, 263, 306–311, 330, 336
   t1_inv_rec_se_single_line.py106992%219, 324, 383–388, 407, 413
   t1_molli_bssfp.py1411391%216, 282–284, 299, 383, 437–442, 454, 460
   t1_t2_spiral_cmrf.py1491292%89, 95, 114, 168, 395, 442–447, 461, 467
   t1rho_se_single_line.py102892%318, 375–380, 399, 405
   t2_multi_echo_se_single_line.py96991%162, 268, 321–326, 344, 350
   t2_t2prep_flash.py1431590%103, 226, 243, 277–279, 291, 375, 437–442, 454, 460
   t2star_multi_echo_flash.py1451490%114, 231, 278–280, 292, 397, 459–464, 476, 482
/home/runner/.local/lib/python3.12/site-packages/mrseq/utils
   EpiReadout.py3319073%52, 61, 193, 197, 244, 318, 321–332, 454, 507–591, 737–743, 763–808
   cartesian_sampling.py37295%38, 80
   sequence_helper.py59493%105, 133–134, 162
   spiral_sampling.py67199%79
TOTAL244925490% 

Tests Skipped Failures Errors Time
1491 0 💤 0 ❌ 0 🔥 3m 12s ⏱️

@schuenke

Copy link
Copy Markdown
Contributor

Can you quickly explain why these should / have to be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants