fix: gate BranchPicker and edit pencil on runtime capabilities#327
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — gates BranchPicker and the edit pencil in thread.tsx behind thread capability checks so they don't appear (and throw) when the runtime doesn't support those operations.
- Gate edit pencil on
capabilities.edit—ActionBarPrimitive.Editis now wrapped in<AuiIf>so it only renders when the runtime hasonEditwired up. - Gate
BranchPickeroncapabilities.switchToBranch—BranchPickerPrimitive.Rootis now wrapped in<AuiIf>so it only renders when the runtime hassetMessageswired up.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
BranchPickerand the user message's edit pencil inthread.tsxrendered unconditionally, regardless of whether the runtime actually supports switching branches or editing — assistant-ui's underlying hooks only check local UI state, notthread.capabilities.conversation-view.tsxnorai-chat-float.tsxwire uponEdit/setMessagesonuseExternalStoreRuntime, so those capabilities are alwaysfalsethere — yet the controls showed up anyway on every message, and clicking them would throw a runtime error ("Runtime does not support switching branches" / "...editing messages").<AuiIf condition={(s) => s.thread.capabilities.switchToBranch}>and<AuiIf condition={(s) => s.thread.capabilities.edit}>so they only render when a runtime genuinely supports them.Fixes #313
Test plan
npx vitest runinapps/web— 315 tests passingnpx tsc -b— no type errorscapabilities.editandcapabilities.switchToBrancharefalsefor the exactuseExternalStoreRuntimeconfig used inconversation-view.tsx/ai-chat-float.tsx🤖 Generated with Claude Code