Opts for portions of the code#13
Open
mdaiter wants to merge 2 commits into
Open
Conversation
PascalPons
reviewed
May 4, 2019
PascalPons
reviewed
May 4, 2019
PascalPons
reviewed
May 4, 2019
PascalPons
reviewed
May 4, 2019
PascalPons
reviewed
May 4, 2019
PascalPons
reviewed
May 4, 2019
| return 0; | ||
| inline Position::position_t getNext() __attribute__((always_inline)) { | ||
| return size ? entries[--size].move : 0; | ||
| } |
Owner
There was a problem hiding this comment.
I prefer avoiding non standard C++ code.
moreover any good C++ compiler will almost certainly inline this code without having to force it.
Author
There was a problem hiding this comment.
http://www.cplusplus.com/articles/1AUq5Di1/
^This is standard. However, I understand if you don't want to include this for readability.
Author
There was a problem hiding this comment.
You could even further optimise this to avoid your jump statement:
size -= static_cast<int>(size > 0);
return (size > 0) * entries[size].move;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @PascalPons ,
Just had a few optimizations I'd like to commit. Most of these are minor that just caught my eye.
Thanks so much