Conversation
Enable -Wall -Wextra -Wdouble-promotion -Werror in CI Bazel builds so regressions are caught immediately. Add float_scalar_test that instantiates L-BFGS, BFGS, gradient descent, conjugate gradient, and Newton with float ScalarType. This exercises code paths that only trigger double-promotion or narrowing when the scalar is not double. Add a separate sanitizer CI job (ASAN + UBSAN) to catch memory errors and undefined behavior. Fix remaining double-promotion sites in lbfgsb.h and armijo.h. Fix armijo.h passing Eigen expression templates where VectorType is required (call .eval() on the expression). Fix unused-variable warnings in test files. Replace deprecated TYPED_TEST_CASE with TYPED_TEST_SUITE. Add [[maybe_unused]] annotations where if-constexpr branches leave parameters unused.
Owner
Author
|
Rebasing this branch onto current main produces an empty branch: commit 04e8742 is patch-identical to 47a6e5e, which is already merged (git cherry confirms). The CI failure here (verify.cc variadic-macro -Wpedantic errors) was likewise fixed on main by 36e97f6. This PR is superseded and can be closed. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable -Wall -Wextra -Wdouble-promotion -Werror in CI Bazel builds so regressions are caught immediately.
Add float_scalar_test that instantiates L-BFGS, BFGS, gradient descent, conjugate gradient, and Newton with float ScalarType. This exercises code paths that only trigger double-promotion or narrowing when the scalar is not double.
Add a separate sanitizer CI job (ASAN + UBSAN) to catch memory errors and undefined behavior.
Fix remaining double-promotion sites in lbfgsb.h and armijo.h. Fix armijo.h passing Eigen expression templates where VectorType is required (call .eval() on the expression).
Fix unused-variable warnings in test files.
Replace deprecated TYPED_TEST_CASE with TYPED_TEST_SUITE. Add [[maybe_unused]] annotations where if-constexpr branches leave parameters unused.