Skip to content

Fix Hallowing flame buff not applying to minions and using wrong element for damage gain as#9794

Open
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak:fix-hallowing-flame-again
Open

Fix Hallowing flame buff not applying to minions and using wrong element for damage gain as#9794
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak:fix-hallowing-flame-again

Conversation

@Paliak
Copy link
Copy Markdown
Contributor

@Paliak Paliak commented Apr 20, 2026

Description of the problem being solved:

#9676 extended handing for Hallowing Flame but i for some reason restricted it to work on player only and used the wrong element for the gain as mod. This PR fixes those problems.

Since i'm clearly an idiot; would be great if someone else played around with Hallowing Flame code to make sure it all works as expected.

I'll add some tests to this PR shortly.

Steps taken to verify a working solution:

  • Ensure that minion gain damage depending on the stack count of hallowing flame
  • Ensure damage of the right element is gained by minion and player when using the
    Marshal of Divinity ascendancy notable.

Link to a build that showcases this PR:

eNrdXN1z4jgSf979K1w874TwYQa2yG4RyFdVmHCQmbl72hK2AF1ki7XlZNi__rolfxJMZMxdXe08zIDcv1Z3S93qbnkY_v7D49YrDUIm_KtG6-KyYVHfES7z11eNr8-3n_qN33_7eTgjcvO0uo4Yxye__fzTUH22tsSXGyr8Kfm3CO6Ee9X4InzayMaZXxh3NiQgjqTBI32lfBRJMRUuvWrIIIKnHmH-QjgvVN4FItqCPA1rSXyXyQTPEabGHU7C8AvxAPxMvS0nQcOSJFhT-S3RpvMHaENCh_ruOKO-i0jgMuI3rFdG3_T0D9PZ0_y5AXr9NJxxsqPBQhJphfDXVWME5iFrOiEe_A0owiOAtLoXvUbzKOI6CkJZAbbYUupmlBeX7TLKWUBvVivqSPZKxwGT4w3xnWySyzJcVdppxCXbckaDnFh2GeL-HfNS0mchCZ_MFnm79Aft4-RCfiz1dyY31xzsaM4cIQ9rn0laDTMTLBR-dSXyiHLrR5yDpxnRzmlIg1ciWVGact7CWzK_iolGASVPK73l5sRlUTilMqBhCm9ftMqwU-KTsQiztWt1jpHOaAAOKwuIyw8AC-oI8PHiJBftnsE8h9GlEz6yFTWnrKRLDKgqzWl63CxM6SozPk2gOQRJM8qFiLghpczCVrtT7j1_5gkH_TLCCf2Rc5cj7PKE5ewefGkmXZ6wZdvl4r0KDAEf20UFopv7WUrZ6aPzD_pdu31pX5bKMtvsQuYQPiU_mBd5EO6fyQvNJuy1yjfqeiN9iGdl0M7nMugtC2h11Fhw9wTUhoiwFNYvDyfMv4c0ZeQ4EWQ3u2xZ-8c818BukBE4vyLtg--YhYOvfqBOg1wicWxZVnQOTorpypJTQ0Q2Rezq2e68vDw-1Zr68Xw7M3UeKXU2d2DfOZHU7DzIko_jZkVaI7Mi4QGz2i0zQAUjIbDESBeDY6CKZrrxabDeLTaMcrcadSLYmGwN4i-aOY82Mndxuko7Jg-taJLvUBSYnVJVZXolYT4qt-zj5tLkZhuTQqILAJea5vSzQPwbqwZeDTYKPBEFhguuiY0USA4UXSPNqRs5ZidYWvxccygXTdVIUSAn55WgIymJ8zIR7trYaGqSSoiifItou4UYgrvBlAGelVAMsFxy9KlnQP0EW9nIo_FYNZ8gozaeIE0UzGfZg5jrgod9BWUycuMp0gWdQrDw4BBQFf5U5Ir80sWB-s-omFOEhkXlTLyB5BvskoTVqCEpyhKhUlEC6v-1M-ZfIDea4MZ3IcECVzCeYx9xaJpn5kEgDcMJkcQKVfvplnFJgwmsNWKRvxVSEjibRxi6JZwvIRpcNfKj-M2NU_BvJGDEl23VqNobbCWLPmyqFhp-GhPuhEqWB38bSctXjarwhXH-hx95S2y_6H8hp4ylLlBuxNuU-Sp0LoXglPhXjRXhIT1A7LHQ-WMZrVbY-gINZKB6fTe3tzfj54dvNzFkQVUstpgLoQwlWYCRHHCVMFqG-tlV4xujb-rhhErCOCyIIzgn25C6RQHy3CCzTppieV6KT-6ZASc4tJ2A4T7IM7r5QQMJOmVPDVip5tI7cbQseNLjJjFiFDfx8qz04TEmodS5iAEXbL4VmeCImSoP3pbwPeMmYyYKoOLPuy1FNwoPGEXCsxBOerZiTkxjturJMVawTVozGfBQjb0iPh4yAOt2XRGdjJlYVXUI96waj5nsL-qQXREdDxmA01y2yCAdFv49bhcDTjecjhjHo2hvZb8IX2128JuMwIDhFKKJPub2GD7JDQ3SJwacwEsCtozkvjvnx01spSrrgpnUiIkuqnrMQ_WIiV0LFVUhGhWemAW1PRZ6xACaZDN5sB4zXII4zy-YPx4zMUJS6hT0TwZNnESF29GrYO77SPHuYV2GqgA4g1yY4tdns5_zG3G85SR82fOXZOxE-FeoDpncHeCi7ujMmKDL1eOAnlePwzPzHRkF1IjB_F06Mt9PQkqQaSpaOKyTwRPxadp6MgedXJ8MV7m_CRrj_4SuKMh66ADIHhmeJYd53QrI6CDdINLUM8p5LWTkT8C6Z2ClVDwckU4zV3z0HrRaCUcdVOJW9ft4GT8wjk5ljCAvuDdNQEs5pfXwPSUcL1AFr8fwXa--DjPs6UVb4rsJu6dDeX_lZRAyBJ6q1ptg67CuDX3q7Q4wSuUaNpNycvhFQNaErHE0-TIcC3_F1hbRbw-oLwsqsSxVUqQjSg4oYCWTnGK6uiIRl4qoWFHiLR9D6ZRs91AeizfYLxCU0XZpQZpZbg8ehVJ4UI2GWTXK_BVnjrQ2CTNrhdwssA4W69TaQMIb84Ki36EbwV0axBwpyoHdp6SWTIvndrf1ASyu3xLE56RbXwpQb7JkgH73A3psu81wVRNExwBwgiL5dz0SmF2O8dJXPQ6uYsKhZWB1U-22aTc66bRksO4Rsy82kLgtsKYOKwiWb_elwl0a2H4fZH8ESlPeVLbLVvejVX7X-TSZLmRrxp9W6rQGg6hj3MAgqcMWV3lKsJ6N3Pw-65vsGHwbhgbUVWsyFpEvF5SvcqIc23fozu_X_xgkW899t-gPeh_A4qsGiJtz4uehnz9a1eJlRTVXzLXNjXdRuiFM3WnhiMDZVPaLIGu5mbhFturFzaPnnVNPvFL3ejfifGe6F_G42UIgCAh_ZmsaqB1kFLSUBkmFmtD3WoP-wNS45asJ52hyEupTVX3Dj88Bpdj5tP4SwvsXuvfAvrAHdrfdhRNsI96wKzZhkOwEKo1LXm9E8n8Cea_7-cLu9jt2W4896pcaB0k7eSFBEH2Wq4ZbaLn67L2jCa0vAi99EQNwkB_Dw_B6N5ktbrHVsPeWF0r1SNfE2SFZknZoYaHm1HBs-sGz0eNjIzfjPyKCBaFqguucIW4Hq5ShOHWiKfIdcRlD81PqRCdmEGcYeqXUoEV9fBPBzb8ROsomVZmNmhaKOw6R6sGPL0pSlfYQipiTJRpNT_TTEOTZn0d_veNiSXgrGfwzp3meoJ2qiTM8YM_UU33A-O3UNtCvqYcPplQSl0jSfJBghCZaoqnkgk8xKJ7lwc1SLM14RgJtYty36CDpPA46iLZ-QphZ5lXfM2RiNf97auutowOBsfrpfktwhyyQ6ZxQZUrnNSxIEPu8tvDfYFdFnif8xQuckFJgul9xf-3DFWN9T7Sn9_6T_cGYck4Y1BoJxwLF-4fHV1ULZ-WkK1nfog5_sxUe7xyef6_dcGVT2HEbp2QHTZs8_V-HB_v_JjrEH5MDXp-1-PHBQ5hFf-A_GF13-UJ9qMS1opDqF1y_U7KFPYrnYf5YPZwD6BMUOeRr7vh7UnGXs463PBdJ8Qy2f6WhNVruwpBwS__vCQsSC4j83mz5df6IF9P4BQ2S5nU5DveUewCpweGwDJ0KHLSeVqsOj8NSdGtbor4M9gmWqAAZQUpOZWU9qwtVZU9cC3dnJZl5Tfv1Ks0rsEtpTD_H3lKr9ibpVp3yHN5RZV9dUy7r2PWw2nZtDr0z2KEKj7uArGSlBU9nXbzhO1-n4fZFPkGAdm1GOZ-sE-6PsGmdyz7tykvaPtfUnXMtTbtq2Kq1tgf8u4p3qhvUahHlkMjtU41Xd-KzrVqnriTd87hSbTnsc1mkW1eSXs19XNcP2jXxnZr4bmU_bFVGtCsjOpUR3XPtqLNtzd4pjM5xFJ8j7J2jXqrrr2XCnMOw3XMpZJ8notpn0Mk-Q7p6tiSpdx67VA3PtXP-Vu2KsFW13GqfYd3OweNMyUG3sgWPA4bNuAOl_0NEQFy6UFdR3ylelIX6vRLV90ouwJK7INWFi9tY-MWSeDuW_QRHu4_XWtjMIsFulP0YB87uM174gQ4c62ArNpQ02MUvD6O4vnCxhdZr2W37l07X7v9iD9qDX7qXg_iHQBBpx90xUFG3NDdSbsNfm823t7eLLZEbsaI_GKcXjvCaWwCB-J9Us_ITytwcwZ_r9dfJaN0e3-5e4NvVle4YJhyH2vxhbGR8PyhgIFlsQ1RfGQrtgx9U69ACAsl8Er9Oy0HlBV6Pua944_0sBM_u48h2C7bINRuHzf1fXvkPKTFqgA==

@LocalIdentity LocalIdentity marked this pull request as ready for review April 20, 2026 19:09
@Paliak Paliak force-pushed the fix-hallowing-flame-again branch from 565b5eb to fd225b8 Compare April 20, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants