Fix Hallowing flame buff not applying to minions and using wrong element for damage gain as#9794
Open
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Fix Hallowing flame buff not applying to minions and using wrong element for damage gain as#9794Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
LocalIdentity
approved these changes
Apr 20, 2026
565b5eb to
fd225b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
#9676 extended handing for Hallowing Flame but i for some reason restricted it to work on player only and used the wrong element for the gain as mod. This PR fixes those problems.
Since i'm clearly an idiot; would be great if someone else played around with Hallowing Flame code to make sure it all works as expected.
I'll add some tests to this PR shortly.
Steps taken to verify a working solution:
Marshal of Divinity ascendancy notable.
Link to a build that showcases this PR: