Skip to content

Use MifImage class instead of mrconvert#43

Open
tsalo wants to merge 12 commits intomainfrom
mif-io
Open

Use MifImage class instead of mrconvert#43
tsalo wants to merge 12 commits intomainfrom
mif-io

Conversation

@tsalo
Copy link
Copy Markdown
Member

@tsalo tsalo commented Mar 27, 2026

Keeping as a draft for now.

I've opened nipy/nibabel#1489 to add the MifImage class to nibabel. Depending on how quickly that PR progresses, we might want to keep copies of the class in ModelArrayIO for a release or two.

NOTE: Since HBCD does not include fixel data, this is a low priority item.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 77.05382% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.76%. Comparing base (dd8cd8a) to head (a2cc521).

Files with missing lines Patch % Lines
src/modelarrayio/utils/mif.py 77.74% 40 Missing and 35 partials ⚠️
src/modelarrayio/cli/h5_to_mif.py 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   69.10%   75.76%   +6.66%     
==========================================
  Files          17       17              
  Lines        1162     1465     +303     
  Branches      211      288      +77     
==========================================
+ Hits          803     1110     +307     
+ Misses        295      256      -39     
- Partials       64       99      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo added the enhancement New feature or request label Mar 28, 2026
@tsalo tsalo marked this pull request as ready for review April 22, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants