You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: this pr overlaps with #1277: pfx_to_pem_files() there does the same PFX/PEM loading with cryptography (pkcs12.load_key_and_certificates + load_pem_x509_certificate + load_pem_private_key). Once both land we'll have two independent loaders in the same file that can drift, could we expose a single helper here (something like load_cert_and_key(pfx_data=..., pfx_pass=..., pem_cert=..., pem_key=...) returning the cryptography objects) and have both from_pfx_data/from_pem and pfx_to_pem_files build on it?
Note: this pr overlaps with #1277: pfx_to_pem_files() there does the same PFX/PEM loading with cryptography (pkcs12.load_key_and_certificates + load_pem_x509_certificate + load_pem_private_key). Once both land we'll have two independent loaders in the same file that can drift, could we expose a single helper here (something like load_cert_and_key(pfx_data=..., pfx_pass=..., pem_cert=..., pem_key=...) returning the cryptography objects) and have both from_pfx_data/from_pem and pfx_to_pem_files build on it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing the oscrypto lib that depend on a fork and use cryptography lib (thanks @azoxlpf for the idea)
Helped with claude max to avoid any regression
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Tested against GOAD lab
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)