Only mark RDP hosts Pwn3d when a real session actually opens - #1348
Open
azoxlpf wants to merge 1 commit into
Open
Only mark RDP hosts Pwn3d when a real session actually opens#1348azoxlpf wants to merge 1 commit into
azoxlpf wants to merge 1 commit into
Conversation
azoxlpf
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
August 5, 2026 20:33
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RDP hosts were marked
Pwn3d!on any successful auth, even with no real session. This produced false positives for accounts with no RDP access right, and forpass-the-hashlogons when restricted admin is disabled (auth succeeds but the interactive logon is refused).Pwn3d!now relies on what the server reports, no marker when RDP access is denied or when no Save Session Info PDU confirms the logon, andPwn3d!only once a real session is confirmed.Must be merged first: skelsec/aardwolf#49
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Disable restricted admin if it isn't already (disabled by default) :
Try logging in as an admin using your password and via pth
Screenshots (if appropriate):
Before :
After :
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)