Update CMakeLists.txt#48
Merged
Merged
Conversation
Owner
|
Well, in that case the date library should be updated to its latest release too. Can you do that in this PR? |
Contributor
Author
|
@PerMalmberg I updated the date library |
Owner
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have already installed
datelibrary's include path, so the property fordatelibrary's include path should bePUBLIC.The change ensures that the
datelibrary's include path is exposed to consumers of the library, which can help prevent build issues when other projects depend on this library.target_include_directoriesproperty for thedatelibrary fromPRIVATEtoPUBLIC, making its headers available to dependent targets.