ExtUtils::ParseXS: make filename hack work with linenumbers => 0 - #24663
Open
mauke wants to merge 1 commit into
Open
ExtUtils::ParseXS: make filename hack work with linenumbers => 0#24663mauke wants to merge 1 commit into
mauke wants to merge 1 commit into
Conversation
We now always pipe our output through ExtUtils::ParseXS::CountLines (so we can always get the current output line number), but this should make no difference to normal output, which checks 'config_WantLineNumbers' before actually switching to a different file with a custom '#line' directive. Which is to say, the documented behavior of 'linenumbers => 0' should remain unchanged. Follow-up to PR Perl#24651.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now always pipe our output through ExtUtils::ParseXS::CountLines (so we can always get the current output line number), but this should make no difference to normal output, which checks
config_WantLineNumbersbefore actually switching to a different file with a custom#linedirective. Which is to say, the documented behavior oflinenumbers => 0should remain unchanged.Follow-up to PR #24651.