Remove unused function warnings#700
Merged
proggeramlug merged 7 commits intoMay 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(test)]where the only remaining users are unit tests.Removed as clearly unused
perry-hir::js_transform; the active class-field rewrite path now handles this behavior.fresh_global, type extraction aliases, unused tarball/error/fetch helpers, unused promise wait wrappers, and stale Redis/codegen helper entry points.build_async_step_driver_direct, and the removed variant had no call sites.Reviewed but intentionally left in place
maybe_force_lazy, because it documents and implements lazy JSON array materialization plumbing that may be exercised by future accessor paths.write_stream_end1_impl, because it appears to be intended support forwriteStream.end(chunk)even though the current method table only registers the zero-argument form.create_fs_constants_object, because it is a compatibility-style runtime helper forfs.constants; removing it would be riskier than the warning suggests.sso_emit_enabled,nanbox_pointer_f64, andstringify_value_with_replacer, because they are tied to partially wired migration or replacer support.compile_for_web,merge_p12_files,get_type_at_position, andencode_nil, because they look like unfinished or externally useful capabilities rather than safe dead-code removals.Validation
git diff --checkcargo buildThe build still reports unrelated warnings for unreachable patterns, unused fields, feature-gated declarations, and intentionally retained helper functions. This PR focuses only on functions that were clear to remove or narrow safely.