Add app metadata introspection APIs#703
Open
TheHypnoo wants to merge 6 commits into
Open
Conversation
12e6e04 to
4e9da56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAppVersion(),getAppBuildNumber(), andgetBundleId()toperry/system.perry.tomlduring compilation and bake it into the LLVM backend as compile-time metadata.perry.tomlparsing.Why
Apps already define
project.version,project.build_number, and bundle identifiers inperry.toml, but there was no runtime-facing API to read those values from TypeScript. This made apps duplicate metadata in hand-maintained constants, which can drift between releases.This implements the feature requested in #673 by exposing the values through
perry/systemwhile keepingperry.tomlas the source of truth.Validation
cargo test -p perry app_metadata_tests --quietcargo check -p perry-codegen --quietcargo test -p perry-dispatch --quietrustfmt --checkon touched Rust filesperry.toml, confirming9.8.7,123, and the target-specific bundle id are returnedCloses #673