Fix crash with swapped Spectral/Stokes axes for large mosaics#366
Fix crash with swapped Spectral/Stokes axes for large mosaics#366thomaswilliamsastro wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=========================================
- Coverage 6.27% 6.26% -0.01%
=========================================
Files 38 38
Lines 15232 15248 +16
Branches 3660 3660
=========================================
Hits 956 956
- Misses 14262 14278 +16
Partials 14 14
|
|
@EOakes it'd be good to get your eyes on this, I think this is basically the same fix as you put in in some other places not too long ago. For some reason, the pipeline spits stuff out as RA/Dec/Stokes/Freq, rather than our normally assumed RA/Dec/Freq/Stokes |
18dd7bb to
0f65bf2
Compare
There was a problem hiding this comment.
Looks good - this approach also matches what copy_mask in casaCubeRoutines.py already does.
Would also be good to correct the hardcoded blc = [0, 0, ichan, istokes] around line 1332, which I think faces the same issue.
Other hardcoded lines (~823, 892, 1118) are iterated over symmetrically, so they'll be mislabeled but won't break things if the axes are swapped.
There was a problem hiding this comment.
Right, I've edited that now so should be fine as well
0f65bf2 to
e19c955
Compare
This PR fixes a crash that can occur if the spectral/Stokes axes are swapped when creating a large mosaic. - Fixed crash if spectral/Stokes axis is swapped when making large mosaics
e19c955 to
8e17dea
Compare
This PR fixes a crash that can occur if the spectral/Stokes axes are swapped when creating a large mosaic.