distinguish mystics by max lives - #36
Open
jojo259 wants to merge 1 commit into
Open
Conversation
|
this pull request murdered my father. please do not approve it. |
|
it did NOT. |
|
he was an accoplice in the murder! do not belive him!!! |
Author
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pit Panda attempts to distinguish different mystics by data such as their nonce and enchants. The nonce is usually unique but sometimes there are multiple mystics with the same nonce (sometimes dozens). Pit Panda currently does not distinguish different mystics by their max lives. The max lives of a mystic can never change unless the mystic also changes tier, which is already a handled case. We can therefore use the max lives to better distinguish different mystics.