Skip to content

Refactor(ProviderIntegrations): Yalidine and Procolis - #26

Open
yacinediaf wants to merge 3 commits into
PiteurStudio:mainfrom
yacinediaf:main
Open

Refactor(ProviderIntegrations): Yalidine and Procolis#26
yacinediaf wants to merge 3 commits into
PiteurStudio:mainfrom
yacinediaf:main

Conversation

@yacinediaf

Copy link
Copy Markdown

Instead of creating a new Guzzle client for each function call, which is resource-intensive.

For example: imagine within a business logic you needed fees with parcels or any other combination of data; here you need to build the Guzzle client multiple times. for each function call :

gerPercels(), getFees()

So it is convenient to create one client on each object creation and use it multiple times. each provider integration has its own client initialization using the appropriate headers.

I have another refactoring ideas on how to restructure the package and remove unnecessary classes in a cleaner way; reach out to me if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant