Refactor(ProviderIntegrations): Yalidine and Procolis - #26
Open
yacinediaf wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating a new Guzzle client for each function call, which is resource-intensive.
For example: imagine within a business logic you needed fees with parcels or any other combination of data; here you need to build the Guzzle client multiple times. for each function call :
gerPercels(), getFees()
So it is convenient to create one client on each object creation and use it multiple times. each provider integration has its own client initialization using the appropriate headers.
I have another refactoring ideas on how to restructure the package and remove unnecessary classes in a cleaner way; reach out to me if you're interested.