feature: add support for uv - #571
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
__enter__ methods in classes like AbstractUnitOfWork usually return self at runtime
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/experiment.py
Line 55 in 75ac358
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/experiment.py
Line 57 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/experiment.py
Line 58 in 75ac358
Use super() instead of super(__class__, self)
benchbuild/benchbuild/experiment.py
Line 63 in 75ac358
Use format specifiers instead of percent format
benchbuild/benchbuild/experiment.py
Lines 137 to 138 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/experiment.py
Lines 188 to 190 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/experiment.py
Lines 188 to 190 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/extensions/base.py
Line 48 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/extensions/base.py
Line 88 in 75ac358
Use X | None for type annotations
Use dict instead of tp.Dict for type annotation
Use key in dict instead of key in dict.keys()
benchbuild/benchbuild/extensions/run.py
Line 79 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/extensions/time.py
Line 53 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/extensions/time.py
Line 54 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/project.py
Line 55 in 75ac358
Use X | Y for type annotations
benchbuild/benchbuild/project.py
Lines 56 to 58 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/project.py
Line 57 in 75ac358
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/project.py
Line 57 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/project.py
Line 92 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/project.py
Line 93 in 75ac358
Do not call setattr with a constant attribute value. It is not any safer than normal property access.
benchbuild/benchbuild/project.py
Line 160 in 75ac358
Do not call setattr with a constant attribute value. It is not any safer than normal property access.
benchbuild/benchbuild/project.py
Line 164 in 75ac358
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/project.py
Line 464 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/project.py
Line 464 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/project.py
Line 492 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/project.py
Line 504 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/project.py
Line 507 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 15 to 24 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 73 to 77 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 82 to 86 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 95 to 107 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 121 to 125 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 130 to 134 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 143 to 147 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 152 to 169 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 174 to 185 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 190 to 269 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 274 to 280 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 285 to 289 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 294 to 298 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 303 to 307 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 316 to 320 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 325 to 329 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 338 to 342 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 347 to 351 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 360 to 364 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/scimark.py
Lines 17 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/bots.py
Lines 29 to 36 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ccrypt.py
Lines 15 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/crafty.py
Lines 15 to 32 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/crocopat.py
Lines 15 to 24 in 75ac358
Avoid extraneous parentheses
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ffmpeg.py
Lines 17 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/gzip.py
Lines 17 to 26 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/js.py
Lines 21 to 28 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lammps.py
Lines 15 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lapack.py
Lines 17 to 24 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lapack.py
Lines 43 to 48 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/leveldb.py
Lines 15 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/linpack.py
Lines 19 to 24 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 15 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 65 to 72 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 18 to 46 in 75ac358
Unnecessary dict() call (rewrite as a literal)
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 96 to 104 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/minisat.py
Lines 15 to 28 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 15 to 60 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 61 to 70 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/povray.py
Lines 15 to 28 in 75ac358
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/python.py
Lines 15 to 22 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/rasdaman.py
Lines 19 to 32 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ruby.py
Lines 15 to 28 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sevenz.py
Lines 15 to 23 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sqlite3.py
Lines 15 to 28 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/tcc.py
Lines 16 to 26 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/x264.py
Lines 18 to 33 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/xz.py
Lines 17 to 25 in 75ac358
.autoportage imported but unused; consider removing, adding to __all__, or using a redundant alias
.bzip2 imported but unused; consider removing, adding to __all__, or using a redundant alias
.crafty imported but unused; consider removing, adding to __all__, or using a redundant alias
.eix imported but unused; consider removing, adding to __all__, or using a redundant alias
.gentoo imported but unused; consider removing, adding to __all__, or using a redundant alias
.gzip imported but unused; consider removing, adding to __all__, or using a redundant alias
.info imported but unused; consider removing, adding to __all__, or using a redundant alias
.lammps imported but unused; consider removing, adding to __all__, or using a redundant alias
.postgresql imported but unused; consider removing, adding to __all__, or using a redundant alias
.sevenz imported but unused; consider removing, adding to __all__, or using a redundant alias
.x264 imported but unused; consider removing, adding to __all__, or using a redundant alias
.xz imported but unused; consider removing, adding to __all__, or using a redundant alias
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
Avoid extraneous parentheses
Avoid extraneous parentheses
Use f-string instead of format call
Use implicit references for positional format fields
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in 75ac358
Mutable default value for class attribute
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/gentoo/x264.py
Lines 20 to 23 in 75ac358
Mutable default value for class attribute
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 20 to 23 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 25 to 33 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 159 to 173 in 75ac358
Class field DOMAIN is defined multiple times
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench-mod.py
Lines 13 to 20 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 81 to 91 in 75ac358
Use a single with statement with multiple contexts instead of nested with statements
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 165 to 166 in 75ac358
Mutable default value for class attribute
benchbuild/benchbuild/projects/test/test.py
Line 161 in 75ac358
datetime.datetime.now() called without a tz argument
benchbuild/benchbuild/settings.py
Line 62 in 75ac358
Dictionary key literal "input" repeated
benchbuild/benchbuild/settings.py
Line 359 in 75ac358
Dictionary key literal "output" repeated
benchbuild/benchbuild/settings.py
Line 360 in 75ac358
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 73 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/source/base.py
Line 387 in 75ac358
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 481 in 75ac358
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 491 in 75ac358
Use set instead of tp.Set for type annotation
benchbuild/benchbuild/source/git.py
Line 22 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 66 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/actions.py
Line 66 in 75ac358
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 78 in 75ac358
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 81 in 75ac358
Do not call setattr with a constant attribute value. It is not any safer than normal property access.
benchbuild/benchbuild/utils/actions.py
Lines 135 to 137 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 204 in 75ac358
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 232 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 587 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in 75ac358
Use platform.system() != "Linux" instead of not platform.system() == "Linux"
benchbuild/benchbuild/utils/bootstrap.py
Line 146 in 75ac358
datetime.datetime.utcfromtimestamp() used
benchbuild/benchbuild/utils/container.py
Line 97 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Line 167 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Line 167 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/path.py
Lines 124 to 126 in 75ac358
Use type instead of tp.Type for type annotation
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/requirements.py
Line 302 in 75ac358
Use list instead of tp.List for type annotation
Use X | None for type annotations
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Remove quotes from type annotation
Use dict instead of tp.Dict for type annotation
Remove quotes from type annotation
Use X | None for type annotations
Use tuple instead of tp.Tuple for type annotation
Use X | None for type annotations
Use f-string instead of format call
Use X | None for type annotations
benchbuild/benchbuild/utils/schema.py
Line 60 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/schema.py
Line 60 in 75ac358
Use implicit references for positional format fields
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in 75ac358
Use f-string instead of format call
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in 75ac358
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 62 in 75ac358
Use of bin(int(match.group(1).replace(",", ""), 16)).count('1')
benchbuild/benchbuild/utils/settings.py
Line 65 in 75ac358
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 90 in 75ac358
Create your own exception
benchbuild/benchbuild/utils/settings.py
Line 97 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/settings.py
Line 282 in 75ac358
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 486 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/utils/settings.py
Line 543 in 75ac358
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 628 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/slurm.py
Line 126 in 75ac358
Use X | None for type annotations
benchbuild/benchbuild/utils/uchroot.py
Line 112 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 112 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 147 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in 75ac358
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 193 in 75ac358
Use X | None for type annotations
Line 23 in 75ac358
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Use X | Y for type annotations
benchbuild/tests/project/test_project.py
Line 66 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/tests/project/test_project.py
Line 66 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/tests/project/test_project.py
Line 67 in 75ac358
Mutable default value for class attribute
benchbuild/tests/project/test_project.py
Line 95 in 75ac358
Use X | Y for type annotations
benchbuild/tests/source/conftest.py
Line 15 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/conftest.py
Line 15 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/tests/source/conftest.py
Line 16 in 75ac358
Use X | Y for type annotations
benchbuild/tests/source/test_source.py
Line 20 in 75ac358
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/test_source.py
Line 20 in 75ac358
Use list instead of tp.List for type annotation
benchbuild/tests/source/test_source.py
Line 21 in 75ac358
Mutable default value for class attribute
benchbuild/tests/test_actions.py
Lines 85 to 88 in 75ac358
Local variable spv is assigned to but never used
benchbuild/tests/test_actions.py
Line 192 in 75ac358
Use X | None for type annotations
benchbuild/tests/test_registry.py
Line 42 in 75ac358
Use tuple instead of tp.Tuple for type annotation
benchbuild/tests/test_registry.py
Line 43 in 75ac358
Use type instead of tp.Type for type annotation
benchbuild/tests/test_registry.py
Line 45 in 75ac358
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 15 in 75ac358
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 15 in 75ac358
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 21 in 75ac358
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 21 in 75ac358
| __all__ = [ | ||
| "main", "bootstrap", "config", "log", "project", "experiment", "run", | ||
| "slurm" | ||
| "main", | ||
| "bootstrap", | ||
| "config", | ||
| "log", | ||
| "project", | ||
| "experiment", | ||
| "run", | ||
| "slurm", | ||
| ] |
There was a problem hiding this comment.
__all__ is not sorted
| __all__ = [ | |
| "main", "bootstrap", "config", "log", "project", "experiment", "run", | |
| "slurm" | |
| "main", | |
| "bootstrap", | |
| "config", | |
| "log", | |
| "project", | |
| "experiment", | |
| "run", | |
| "slurm", | |
| ] | |
| __all__ = [ | |
| "bootstrap", | |
| "config", | |
| "experiment", | |
| "log", | |
| "main", | |
| "project", | |
| "run", | |
| "slurm", | |
| ] |
| ( | ||
| "{0} @ {1} - {2} id: {3} group: {4}".format( | ||
| tup.end, | ||
| tup.experiment_name, | ||
| tup.project_name, | ||
| tup.experiment_group, | ||
| tup.run_group, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Avoid extraneous parentheses
| ( | |
| "{0} @ {1} - {2} id: {3} group: {4}".format( | |
| tup.end, | |
| tup.experiment_name, | |
| tup.project_name, | |
| tup.experiment_group, | |
| tup.run_group, | |
| ) | |
| ) | |
| "{0} @ {1} - {2} id: {3} group: {4}".format( | |
| tup.end, | |
| tup.experiment_name, | |
| tup.project_name, | |
| tup.experiment_group, | |
| tup.run_group, | |
| ) | |
| "{0} @ {1} - {2} id: {3} group: {4}".format( | ||
| tup.end, | ||
| tup.experiment_name, | ||
| tup.project_name, | ||
| tup.experiment_group, | ||
| tup.run_group, | ||
| ) |
There was a problem hiding this comment.
Use implicit references for positional format fields
| "{0} @ {1} - {2} id: {3} group: {4}".format( | |
| tup.end, | |
| tup.experiment_name, | |
| tup.project_name, | |
| tup.experiment_group, | |
| tup.run_group, | |
| ) | |
| "{} @ {} - {} id: {} group: {}".format( | |
| tup.end, | |
| tup.experiment_name, | |
| tup.project_name, | |
| tup.experiment_group, | |
| tup.run_group, | |
| ) |
| "{0} @ {1} - {2} id: {3} group: {4}".format( | ||
| tup.end, | ||
| tup.experiment_name, | ||
| tup.project_name, | ||
| tup.experiment_group, | ||
| tup.run_group, | ||
| ) |
There was a problem hiding this comment.
Use f-string instead of format call
| "{0} @ {1} - {2} id: {3} group: {4}".format( | |
| tup.end, | |
| tup.experiment_name, | |
| tup.project_name, | |
| tup.experiment_group, | |
| tup.run_group, | |
| ) | |
| f"{tup.end} @ {tup.experiment_name} - {tup.project_name} id: {tup.experiment_group} group: {tup.run_group}" |
| ( | ||
| "{0} @ {1} - {2} id: {3} group: {4} status: {5}".format( | ||
| run.end, | ||
| run.experiment_name, | ||
| run.project_name, | ||
| run.experiment_group, | ||
| run.run_group, | ||
| log.status, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Avoid extraneous parentheses
| ( | |
| "{0} @ {1} - {2} id: {3} group: {4} status: {5}".format( | |
| run.end, | |
| run.experiment_name, | |
| run.project_name, | |
| run.experiment_group, | |
| run.run_group, | |
| log.status, | |
| ) | |
| ) | |
| "{0} @ {1} - {2} id: {3} group: {4} status: {5}".format( | |
| run.end, | |
| run.experiment_name, | |
| run.project_name, | |
| run.experiment_group, | |
| run.run_group, | |
| log.status, | |
| ) | |
| _handle_command(cmd_handlers, message, queue) | ||
| else: | ||
| raise Exception(f'{message} was not an Event or Command') | ||
| raise Exception(f"{message} was not an Event or Command") |
| ( | ||
| "Command could not be executed, because I could not find a required" | ||
| f" image: {ex}" | ||
| ) |
There was a problem hiding this comment.
| ( | ||
| f"[bold]{event.name}[/bold]\n" | ||
| f"[red]Failed to create layer while building {event.image_tag}.[/red]\n" | ||
| ) |
There was a problem hiding this comment.
| import abc | ||
| import logging | ||
| import sys | ||
| import typing as tp |
There was a problem hiding this comment.
| import abc | ||
| import logging | ||
| import sys | ||
| import typing as tp |
There was a problem hiding this comment.
There was a problem hiding this comment.
Use f-string instead of format call
benchbuild/benchbuild/cli/run.py
Lines 113 to 119 in 75ac358
There was a problem hiding this comment.
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/bots.py
Lines 38 to 50 in 75ac358
There was a problem hiding this comment.
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/bots.py
Lines 52 to 78 in 75ac358
There was a problem hiding this comment.
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 24 to 42 in 75ac358
There was a problem hiding this comment.
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 74 to 92 in 75ac358
There was a problem hiding this comment.
Return the negated condition directly
benchbuild/benchbuild/utils/requirements.py
Lines 228 to 234 in 75ac358
There was a problem hiding this comment.
Use f-string instead of format call
benchbuild/benchbuild/utils/schema.py
Lines 251 to 256 in 75ac358
There was a problem hiding this comment.
Import block is un-sorted or un-formatted
benchbuild/tests/e2e/test_containers.py
Lines 1 to 17 in 75ac358
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 15 to 24 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 73 to 77 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 82 to 86 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 95 to 107 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 121 to 125 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 130 to 134 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 143 to 147 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 152 to 169 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 174 to 185 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 190 to 269 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 274 to 280 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 285 to 289 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 294 to 298 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 303 to 307 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 316 to 320 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 325 to 329 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 338 to 342 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 347 to 351 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/rodinia.py
Lines 360 to 364 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/apollo/scimark.py
Lines 17 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/bots.py
Lines 29 to 36 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ccrypt.py
Lines 15 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/crafty.py
Lines 15 to 32 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/crocopat.py
Lines 15 to 24 in c39e4fc
Avoid extraneous parentheses
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ffmpeg.py
Lines 17 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/gzip.py
Lines 17 to 26 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/js.py
Lines 21 to 28 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lammps.py
Lines 15 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lapack.py
Lines 17 to 24 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lapack.py
Lines 43 to 48 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/leveldb.py
Lines 15 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/linpack.py
Lines 19 to 24 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 15 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 65 to 72 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 18 to 46 in c39e4fc
Unnecessary dict() call (rewrite as a literal)
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 96 to 104 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/minisat.py
Lines 15 to 28 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 15 to 60 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 61 to 70 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/povray.py
Lines 15 to 28 in c39e4fc
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/python.py
Lines 15 to 22 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/rasdaman.py
Lines 19 to 32 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ruby.py
Lines 15 to 28 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sevenz.py
Lines 15 to 23 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sqlite3.py
Lines 15 to 28 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/tcc.py
Lines 16 to 26 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/x264.py
Lines 18 to 33 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/xz.py
Lines 17 to 25 in c39e4fc
.autoportage imported but unused; consider removing, adding to __all__, or using a redundant alias
.bzip2 imported but unused; consider removing, adding to __all__, or using a redundant alias
.crafty imported but unused; consider removing, adding to __all__, or using a redundant alias
.eix imported but unused; consider removing, adding to __all__, or using a redundant alias
.gentoo imported but unused; consider removing, adding to __all__, or using a redundant alias
.gzip imported but unused; consider removing, adding to __all__, or using a redundant alias
.info imported but unused; consider removing, adding to __all__, or using a redundant alias
.lammps imported but unused; consider removing, adding to __all__, or using a redundant alias
.postgresql imported but unused; consider removing, adding to __all__, or using a redundant alias
.sevenz imported but unused; consider removing, adding to __all__, or using a redundant alias
.x264 imported but unused; consider removing, adding to __all__, or using a redundant alias
.xz imported but unused; consider removing, adding to __all__, or using a redundant alias
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
Avoid extraneous parentheses
Avoid extraneous parentheses
Use f-string instead of format call
Use implicit references for positional format fields
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in c39e4fc
Mutable default value for class attribute
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/gentoo/x264.py
Lines 20 to 23 in c39e4fc
Mutable default value for class attribute
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 20 to 23 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 25 to 33 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 159 to 173 in c39e4fc
Class field DOMAIN is defined multiple times
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench-mod.py
Lines 13 to 20 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 81 to 91 in c39e4fc
Use a single with statement with multiple contexts instead of nested with statements
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 165 to 166 in c39e4fc
Mutable default value for class attribute
benchbuild/benchbuild/projects/test/test.py
Line 161 in c39e4fc
datetime.datetime.now() called without a tz argument
benchbuild/benchbuild/settings.py
Line 62 in c39e4fc
Dictionary key literal "input" repeated
benchbuild/benchbuild/settings.py
Line 359 in c39e4fc
Dictionary key literal "output" repeated
benchbuild/benchbuild/settings.py
Line 360 in c39e4fc
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 73 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/source/base.py
Line 387 in c39e4fc
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 481 in c39e4fc
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 491 in c39e4fc
Use set instead of tp.Set for type annotation
benchbuild/benchbuild/source/git.py
Line 22 in c39e4fc
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 66 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/actions.py
Line 66 in c39e4fc
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 78 in c39e4fc
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 81 in c39e4fc
Do not call setattr with a constant attribute value. It is not any safer than normal property access.
benchbuild/benchbuild/utils/actions.py
Lines 135 to 137 in c39e4fc
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 204 in c39e4fc
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 232 in c39e4fc
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 587 in c39e4fc
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in c39e4fc
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in c39e4fc
Use platform.system() != "Linux" instead of not platform.system() == "Linux"
benchbuild/benchbuild/utils/bootstrap.py
Line 146 in c39e4fc
datetime.datetime.utcfromtimestamp() used
benchbuild/benchbuild/utils/container.py
Line 97 in c39e4fc
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in c39e4fc
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Line 167 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Line 167 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/path.py
Lines 124 to 126 in c39e4fc
Use type instead of tp.Type for type annotation
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/requirements.py
Line 302 in c39e4fc
Use list instead of tp.List for type annotation
Use X | None for type annotations
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Remove quotes from type annotation
Use dict instead of tp.Dict for type annotation
Remove quotes from type annotation
Use X | None for type annotations
Use tuple instead of tp.Tuple for type annotation
Use X | None for type annotations
Use f-string instead of format call
Use X | None for type annotations
benchbuild/benchbuild/utils/schema.py
Line 60 in c39e4fc
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/schema.py
Line 60 in c39e4fc
Use implicit references for positional format fields
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in c39e4fc
Use f-string instead of format call
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in c39e4fc
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 62 in c39e4fc
Use of bin(int(match.group(1).replace(",", ""), 16)).count('1')
benchbuild/benchbuild/utils/settings.py
Line 65 in c39e4fc
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 90 in c39e4fc
Create your own exception
benchbuild/benchbuild/utils/settings.py
Line 97 in c39e4fc
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/settings.py
Line 282 in c39e4fc
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 486 in c39e4fc
Use X | None for type annotations
benchbuild/benchbuild/utils/settings.py
Line 543 in c39e4fc
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 628 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/slurm.py
Line 126 in c39e4fc
Use X | None for type annotations
benchbuild/benchbuild/utils/uchroot.py
Line 112 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 112 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 147 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in c39e4fc
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 193 in c39e4fc
Use X | None for type annotations
Line 23 in c39e4fc
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Use X | Y for type annotations
benchbuild/tests/project/test_project.py
Line 66 in c39e4fc
Use dict instead of tp.Dict for type annotation
benchbuild/tests/project/test_project.py
Line 66 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/tests/project/test_project.py
Line 67 in c39e4fc
Mutable default value for class attribute
benchbuild/tests/project/test_project.py
Line 95 in c39e4fc
Use X | Y for type annotations
benchbuild/tests/source/conftest.py
Line 15 in c39e4fc
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/conftest.py
Line 15 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/tests/source/conftest.py
Line 16 in c39e4fc
Use X | Y for type annotations
benchbuild/tests/source/test_source.py
Line 20 in c39e4fc
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/test_source.py
Line 20 in c39e4fc
Use list instead of tp.List for type annotation
benchbuild/tests/source/test_source.py
Line 21 in c39e4fc
Mutable default value for class attribute
benchbuild/tests/test_actions.py
Lines 85 to 88 in c39e4fc
Local variable spv is assigned to but never used
benchbuild/tests/test_actions.py
Line 192 in c39e4fc
Use X | None for type annotations
benchbuild/tests/test_registry.py
Line 42 in c39e4fc
Use tuple instead of tp.Tuple for type annotation
benchbuild/tests/test_registry.py
Line 43 in c39e4fc
Use type instead of tp.Type for type annotation
benchbuild/tests/test_registry.py
Line 45 in c39e4fc
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 15 in c39e4fc
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 15 in c39e4fc
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 21 in c39e4fc
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 21 in c39e4fc
| import abc | ||
| import logging | ||
| import sys | ||
| import typing as tp |
There was a problem hiding this comment.
| def create_image( | ||
| self, tag: str, layers: tp.List[model.Layer] | ||
| ) -> model.Container: | ||
| def create_image(self, tag: str, layers: tp.List[model.Layer]) -> model.Container: |
There was a problem hiding this comment.
| def _create_image( | ||
| self, tag: str, layers: tp.List[model.Layer] | ||
| ) -> model.Container: | ||
| def _create_image(self, tag: str, layers: tp.List[model.Layer]) -> model.Container: |
There was a problem hiding this comment.
| def __new__( | ||
| mcs: tp.Type[tp.Any], name: str, bases: tp.Tuple[type, ...], | ||
| attrs: tp.Dict[str, tp.Any], *args: tp.Any, **kwargs: tp.Any | ||
| mcs: tp.Type[tp.Any], |
| attrs: tp.Dict[str, tp.Any], *args: tp.Any, **kwargs: tp.Any | ||
| mcs: tp.Type[tp.Any], | ||
| name: str, | ||
| bases: tp.Tuple[type, ...], |
| def __split_project_input__( | ||
| project_input: str | ||
| ) -> tp.Tuple[str, tp.Optional[str]]: | ||
| def __split_project_input__(project_input: str) -> tp.Tuple[str, tp.Optional[str]]: |
There was a problem hiding this comment.
| def __split_project_input__( | ||
| project_input: str | ||
| ) -> tp.Tuple[str, tp.Optional[str]]: | ||
| def __split_project_input__(project_input: str) -> tp.Tuple[str, tp.Optional[str]]: |
| def __add_indexed_filters__( | ||
| project: ProjectT, versions: tp.List[str] | ||
| ) -> ProjectT: | ||
| def __add_indexed_filters__(project: ProjectT, versions: tp.List[str]) -> ProjectT: |
There was a problem hiding this comment.
| def __add_named_filters__( | ||
| project: ProjectT, versions: tp.Dict[str, str] | ||
| ) -> ProjectT: | ||
| def __add_named_filters__(project: ProjectT, versions: tp.Dict[str, str]) -> ProjectT: |
There was a problem hiding this comment.
| named_sources: tp.Dict[str, source.base.FetchableSource] = { | ||
| s.key: s for s in sources | ||
| } | ||
| named_sources: tp.Dict[str, FetchableSource] = {s.key: s for s in sources} |
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lapack.py
Lines 43 to 48 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/leveldb.py
Lines 15 to 22 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/linpack.py
Lines 19 to 24 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 15 to 22 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/lulesh.py
Lines 65 to 72 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 18 to 46 in dbc0932
Unnecessary dict() call (rewrite as a literal)
benchbuild/benchbuild/projects/benchbuild/mcrypt.py
Lines 96 to 104 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/minisat.py
Lines 15 to 28 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 15 to 60 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/openssl.py
Lines 61 to 70 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/povray.py
Lines 15 to 28 in dbc0932
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/python.py
Lines 15 to 22 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/rasdaman.py
Lines 19 to 32 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/ruby.py
Lines 15 to 28 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sevenz.py
Lines 15 to 23 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/sqlite3.py
Lines 15 to 28 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/tcc.py
Lines 16 to 26 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/x264.py
Lines 18 to 33 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/benchbuild/xz.py
Lines 17 to 25 in dbc0932
.autoportage imported but unused; consider removing, adding to __all__, or using a redundant alias
.bzip2 imported but unused; consider removing, adding to __all__, or using a redundant alias
.crafty imported but unused; consider removing, adding to __all__, or using a redundant alias
.eix imported but unused; consider removing, adding to __all__, or using a redundant alias
.gentoo imported but unused; consider removing, adding to __all__, or using a redundant alias
.gzip imported but unused; consider removing, adding to __all__, or using a redundant alias
.info imported but unused; consider removing, adding to __all__, or using a redundant alias
.lammps imported but unused; consider removing, adding to __all__, or using a redundant alias
.postgresql imported but unused; consider removing, adding to __all__, or using a redundant alias
.sevenz imported but unused; consider removing, adding to __all__, or using a redundant alias
.x264 imported but unused; consider removing, adding to __all__, or using a redundant alias
.xz imported but unused; consider removing, adding to __all__, or using a redundant alias
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
Avoid extraneous parentheses
Avoid extraneous parentheses
Use f-string instead of format call
Use implicit references for positional format fields
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/projects/gentoo/gentoo.py
Lines 209 to 212 in dbc0932
Mutable default value for class attribute
Use implicit references for positional format fields
Use f-string instead of format call
Mutable default value for class attribute
benchbuild/benchbuild/projects/gentoo/x264.py
Lines 20 to 23 in dbc0932
Mutable default value for class attribute
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 20 to 23 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 25 to 33 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/lnt/lnt.py
Lines 159 to 173 in dbc0932
Class field DOMAIN is defined multiple times
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench-mod.py
Lines 13 to 20 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 81 to 91 in dbc0932
Use a single with statement with multiple contexts instead of nested with statements
benchbuild/benchbuild/projects/polybench/polybench.py
Lines 165 to 166 in dbc0932
Mutable default value for class attribute
benchbuild/benchbuild/projects/test/test.py
Line 161 in dbc0932
datetime.datetime.now() called without a tz argument
benchbuild/benchbuild/settings.py
Line 62 in dbc0932
Dictionary key literal "input" repeated
benchbuild/benchbuild/settings.py
Line 359 in dbc0932
Dictionary key literal "output" repeated
benchbuild/benchbuild/settings.py
Line 360 in dbc0932
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 73 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/source/base.py
Line 387 in dbc0932
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 481 in dbc0932
Use type instead of tp.Type for type annotation
benchbuild/benchbuild/source/base.py
Line 491 in dbc0932
Use set instead of tp.Set for type annotation
benchbuild/benchbuild/source/git.py
Line 22 in dbc0932
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 66 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/actions.py
Line 66 in dbc0932
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 78 in dbc0932
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 81 in dbc0932
Do not call setattr with a constant attribute value. It is not any safer than normal property access.
benchbuild/benchbuild/utils/actions.py
Lines 135 to 137 in dbc0932
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 204 in dbc0932
Remove quotes from type annotation
benchbuild/benchbuild/utils/actions.py
Line 232 in dbc0932
Use X | None for type annotations
benchbuild/benchbuild/utils/actions.py
Line 587 in dbc0932
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 131 in dbc0932
Use implicit references for positional format fields
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/bootstrap.py
Line 135 in dbc0932
Use platform.system() != "Linux" instead of not platform.system() == "Linux"
benchbuild/benchbuild/utils/bootstrap.py
Line 146 in dbc0932
datetime.datetime.utcfromtimestamp() used
benchbuild/benchbuild/utils/container.py
Line 97 in dbc0932
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Lines 106 to 108 in dbc0932
Use implicit references for positional format fields
benchbuild/benchbuild/utils/container.py
Line 167 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/container.py
Line 167 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/path.py
Lines 124 to 126 in dbc0932
Use type instead of tp.Type for type annotation
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/requirements.py
Line 302 in dbc0932
Use list instead of tp.List for type annotation
Use X | None for type annotations
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Use list instead of tp.List for type annotation
Remove quotes from type annotation
Use dict instead of tp.Dict for type annotation
Remove quotes from type annotation
Use X | None for type annotations
Use tuple instead of tp.Tuple for type annotation
Use X | None for type annotations
Use f-string instead of format call
Use X | None for type annotations
benchbuild/benchbuild/utils/schema.py
Line 60 in dbc0932
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/schema.py
Line 60 in dbc0932
Use implicit references for positional format fields
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in dbc0932
Use f-string instead of format call
benchbuild/benchbuild/utils/schema.py
Lines 187 to 189 in dbc0932
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 62 in dbc0932
Use of bin(int(match.group(1).replace(",", ""), 16)).count('1')
benchbuild/benchbuild/utils/settings.py
Line 65 in dbc0932
Use a context manager for opening files
benchbuild/benchbuild/utils/settings.py
Line 90 in dbc0932
Create your own exception
benchbuild/benchbuild/utils/settings.py
Line 97 in dbc0932
Use dict instead of tp.Dict for type annotation
benchbuild/benchbuild/utils/settings.py
Line 282 in dbc0932
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 486 in dbc0932
Use X | None for type annotations
benchbuild/benchbuild/utils/settings.py
Line 543 in dbc0932
Use format specifiers instead of percent format
benchbuild/benchbuild/utils/settings.py
Line 628 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/slurm.py
Line 126 in dbc0932
Use X | None for type annotations
benchbuild/benchbuild/utils/uchroot.py
Line 112 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 112 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 147 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in dbc0932
Use tuple instead of tp.Tuple for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 174 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/benchbuild/utils/uchroot.py
Line 193 in dbc0932
Use X | None for type annotations
Line 23 in dbc0932
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Unnecessary dict() call (rewrite as a literal)
Use X | Y for type annotations
benchbuild/tests/project/test_project.py
Line 66 in dbc0932
Use dict instead of tp.Dict for type annotation
benchbuild/tests/project/test_project.py
Line 66 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/tests/project/test_project.py
Line 67 in dbc0932
Mutable default value for class attribute
benchbuild/tests/project/test_project.py
Line 95 in dbc0932
Use X | Y for type annotations
benchbuild/tests/source/conftest.py
Line 15 in dbc0932
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/conftest.py
Line 15 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/tests/source/conftest.py
Line 16 in dbc0932
Use X | Y for type annotations
benchbuild/tests/source/test_source.py
Line 20 in dbc0932
Use dict instead of tp.Dict for type annotation
benchbuild/tests/source/test_source.py
Line 20 in dbc0932
Use list instead of tp.List for type annotation
benchbuild/tests/source/test_source.py
Line 21 in dbc0932
Mutable default value for class attribute
benchbuild/tests/test_actions.py
Lines 85 to 88 in dbc0932
Local variable spv is assigned to but never used
benchbuild/tests/test_actions.py
Line 192 in dbc0932
Use X | None for type annotations
benchbuild/tests/test_registry.py
Line 42 in dbc0932
Use tuple instead of tp.Tuple for type annotation
benchbuild/tests/test_registry.py
Line 43 in dbc0932
Use type instead of tp.Type for type annotation
benchbuild/tests/test_registry.py
Line 45 in dbc0932
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 15 in dbc0932
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 15 in dbc0932
Use implicit references for positional format fields
benchbuild/tests/test_strategy_polyjit.py
Line 21 in dbc0932
Use f-string instead of format call
benchbuild/tests/test_strategy_polyjit.py
Line 21 in dbc0932
| SOURCE = [ | ||
| HTTP(remote={ | ||
| '3.1': 'http://www.cs.virginia.edu/' | ||
| '~kw5na/lava/Rodinia/Packages/Current/3.1/' | ||
| 'rodinia_3.1.tar.bz2' | ||
| }, | ||
| local='rodinia.tar.bz2') | ||
| HTTP( | ||
| remote={ | ||
| "3.1": "http://www.cs.virginia.edu/" | ||
| "~kw5na/lava/Rodinia/Packages/Current/3.1/" | ||
| "rodinia_3.1.tar.bz2" | ||
| }, | ||
| local="rodinia.tar.bz2", | ||
| ) | ||
| ] |
| CONFIG = { | ||
| "dir": "openmp/backprop", | ||
| "src": { | ||
| NAME: [ | ||
| "backprop_kernel.c", "imagenet.c", "facetrain.c", "backprop.c" | ||
| ] | ||
| }, | ||
| "flags": ["-fopenmp", "-lm"] | ||
| "src": {NAME: ["backprop_kernel.c", "imagenet.c", "facetrain.c", "backprop.c"]}, | ||
| "flags": ["-fopenmp", "-lm"], | ||
| } |
| CONFIG = { | ||
| "dir": "openmp/bfs", | ||
| "src": { | ||
| NAME: ["bfs.cpp"] | ||
| }, | ||
| "flags": ["-fopenmp", "-UOPEN"] | ||
| "src": {NAME: ["bfs.cpp"]}, | ||
| "flags": ["-fopenmp", "-UOPEN"], | ||
| } |
| CONFIG = { | ||
| "dir": "openmp/b+tree", | ||
| "src": { | ||
| "b+tree.out": [ | ||
| "./main.c", "./kernel/kernel_cpu.c", "./kernel/kernel_cpu_2.c", | ||
| "./util/timer/timer.c", "./util/num/num.c" | ||
| "./main.c", | ||
| "./kernel/kernel_cpu.c", | ||
| "./kernel/kernel_cpu_2.c", | ||
| "./util/timer/timer.c", | ||
| "./util/num/num.c", | ||
| ] | ||
| }, | ||
| "flags": ["-fopenmp", "-lm"] | ||
| "flags": ["-fopenmp", "-lm"], | ||
| } |
| CONFIG = { | ||
| "dir": "openmp/heartwall", | ||
| "src": { | ||
| NAME: ["./AVI/avimod.c", "./AVI/avilib.c", "./main.c"] | ||
| }, | ||
| "flags": ["-I./AVI", "-fopenmp", "-lm"] | ||
| "src": {NAME: ["./AVI/avimod.c", "./AVI/avilib.c", "./main.c"]}, | ||
| "flags": ["-I./AVI", "-fopenmp", "-lm"], | ||
| } |
| SOURCE = [ | ||
| HTTP( | ||
| remote={'3.1.3': 'http://ffmpeg.org/releases/ffmpeg-3.1.3.tar.bz2'}, | ||
| local='ffmpeg.tar.bz2' | ||
| remote={"3.1.3": "http://ffmpeg.org/releases/ffmpeg-3.1.3.tar.bz2"}, | ||
| local="ffmpeg.tar.bz2", | ||
| ) | ||
| ] |
| SOURCE = [ | ||
| HTTP( | ||
| remote={'1.6': 'http://ftpmirror.gnu.org/gzip/gzip-1.6.tar.xz'}, | ||
| local='gzip.tar.xz' | ||
| remote={"1.6": "http://ftpmirror.gnu.org/gzip/gzip-1.6.tar.xz"}, | ||
| local="gzip.tar.xz", | ||
| ), | ||
| HTTP( | ||
| remote={'1.0': 'http://lairosiel.de/dist/compression.tar.gz'}, | ||
| local='compression.tar.gz' | ||
| ) | ||
| remote={"1.0": "http://lairosiel.de/dist/compression.tar.gz"}, | ||
| local="compression.tar.gz", | ||
| ), | ||
| ] |
| SOURCE = [ | ||
| Git( | ||
| remote='https://github.com/mozilla/gecko-dev.git', | ||
| local='gecko-dev.git', | ||
| remote="https://github.com/mozilla/gecko-dev.git", | ||
| local="gecko-dev.git", | ||
| limit=5, | ||
| refspec='HEAD' | ||
| refspec="HEAD", | ||
| ) | ||
| ] |
| SOURCE = [ | ||
| Git( | ||
| remote='https://github.com/lammps/lammps', | ||
| local='lammps.git', | ||
| remote="https://github.com/lammps/lammps", | ||
| local="lammps.git", | ||
| limit=5, | ||
| refspec='HEAD' | ||
| refspec="HEAD", | ||
| ) | ||
| ] |
| SOURCE = [ | ||
| Git( | ||
| remote='https://github.com/xianyi/OpenBLAS', | ||
| local='OpenBLAS', | ||
| remote="https://github.com/xianyi/OpenBLAS", | ||
| local="OpenBLAS", | ||
| limit=5, | ||
| refspec='HEAD' | ||
| refspec="HEAD", | ||
| ) | ||
| ] |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 52.53% 50.55% -1.99%
==========================================
Files 120 120
Lines 8318 8304 -14
Branches 1064 720 -344
==========================================
- Hits 4370 4198 -172
- Misses 3763 3904 +141
- Partials 185 202 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This adds support for uv. Most github workflows are adapted and an appropriate pyproject.toml is provided.