[wip] merge#842
Open
tgauth wants to merge 562 commits into
Open
Conversation
only bz3869 OpenBSD-Commit-ID: e7848fec50d15cc142fed946aa8f79abef3c5be7
potentially reuse the variable. Fixes Coverity CID 405057. OpenBSD-Regress-ID: c52e86502b33bfa6e448448a74a0217dd519dd58
OpenBSD-Commit-ID: 55f5b9eaeb826a25cfb506a78136094275a71bcb
OpenBSD-Commit-ID: 8aa48451fe5c37f04a339450c4ed9cfb8f4c288f
OpenBSD-Commit-ID: 55058ac3d477e4c696575039f5b275522b99ffea
The array is bounded by a NULL sentinel which already prevents this, however since we check the bit vector for overflow Coverity assumes that check is for the devices array and flags it as a potential overflow. Adding this additional check on the array placates CID 896018. ok djm@ deraadt@ OpenBSD-Commit-ID: e92fff41341b38e4206a70655cc9acaaa032ebee
Android libc can return NULL pw_gecos, for example.
The `host` parameter to audit_log_acct_message() is documented as
follows:
host - The hostname if known. If not available pass a NULL.
but we pass the string "UNKNOWN" in case we don't know the hostname.
Make sure we pass NULL instead.
This avoids having the audit system attempt to perform a DNS lookup on
the hostname "UNKNOWN", which tends to result in long delays when
attempting to login.
by Boris Tonofa; ok dtucker OpenBSD-Commit-ID: 410cdd05242304bd0196b9172ce5fcaf89d2d8ce
share common utf-8 characters that don't encode to a complete codepoint from menthu.zhou via GHPR#587; ok dtucker@ OpenBSD-Commit-ID: e07e4d8a8cac032ab536570b8214e6ef6839b585
could be ignored if a subsequent write succeeded. This is unlikely but technically possible because sftp servers are allowed to reorder requests. Reported by Graziano Stefani, ok tb@ OpenBSD-Commit-ID: 03904bce2c7f787223d01d7e1179fde15753eca3
older shells. From Sevan Janiyan via openssh-unix-dev. OpenBSD-Regress-ID: 67c11a5cff6ef23538c77e9b29d538e175e6cfe3
variables will be used again. Should prevent Coverity "potential use after free" warnings. OpenBSD-Regress-ID: 24d141657d25977e41dfb0c58e9b74ab093972bf
This fixes the build when the directory path containing a space. Found by Sevan Janiyan, tested by Job Snijders. This doesn't fix "make tests", however that is a different, pre-existing problem that needs to be addressed separately.
Fixes build on Solaris, AIX and probably others.
some multibyte sequences) as it breaks the common case for tab completion. Will deal with it properly after release. OpenBSD-Commit-ID: 196d00f5ff19579214de45357f16a1fb2d624be1
in -portable when there are no kbdint devices present. ok djm@ OpenBSD-Commit-ID: c1c050cecd642d6073c792201908fd225191df93
makes things simpler for portable; from Mike Frysinger OpenBSD-Commit-ID: 717e93403fd1108e175afd7451b5a4ab46a598fe
OpenBSD-Commit-ID: b47ed4fa93b781c7ec8ae2936526a290f4e17e1f
ok dtucker@ OpenBSD-Commit-ID: a70fd2e1b23089260e8f5a7921b0debc06b011cb
from the beginning of the buffer not the end of what was written. Fix, since we want modpipe to corrupt data for testing purposes deliberately not accidentally. ok djm@ OpenBSD-Regress-ID: 50ca74d287445c58944f070bb92dc13b1d054b43
OpenBSD-Commit-ID: 2a232c2d2fc05a23519f69bc29e6d8c076b97d97
has a tty attached as this causes side effects, e.g. in channel_handle_rfd(). bz3872 ok markus@ OpenBSD-Commit-ID: 4cd8a9f641498ca6089442e59bad0fd3dcbe85f8
This fixes the build on macOS prior to 10.12 Sierra, since it does not have it. Found and tested by Sevan Janiyan.
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…icate Upstream 52411f1 (batch 94) added a portable clock_gettime shim to openbsd-compat/bsd-misc.c/h guarded by #ifndef HAVE_CLOCK_GETTIME. Remove the fork's win32compat clock_gettime and its clockid_t/CLOCK_* declarations in inc/sys/time.h so the single portable openbsd-compat implementation is used, reducing fork-specific code to maintain. openbsd_compat.lib is linked into every binary (incl. unit tests), so the symbol resolves without pulling from fido2.lib and without a duplicate-symbol collision. Functionally equivalent on Windows: both return wall-clock time; CLOCK_MONOTONIC is undefined so monotime_ts() falls through to CLOCK_REALTIME.
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
…merge-v10.3P1-20260420
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Batch 99 added upstream tests exercising recursive transfers where the source ends in dotdot. All three failed on Windows for two distinct reasons. scp.sh and scp3.sh: the fork defines scpopts as a bash array on Windows (to preserve the quoted -S option) and every other test expands it via the array form. The new dotdot tests arrived from upstream using scalar scpopts, which on Windows expands only the first array element and drops the remaining options, causing copy failed. Changed the new blocks to use the array expansion form to match the established pattern. sftp-cmds.sh: exposed a latent bug in the win32 basename. After stripping trailing slashes into bname, when the name had no internal separator it returned the original path (still containing the trailing slash) instead of bname. glob with GLOB_MARK marks dotdot with a trailing slash, so basename returned the marked form rather than dotdot, causing upstream new strcmp filename equals dotdot fix to miss on Windows and the upload to land in the parent directory, leaving the destination empty. Return bname instead of path. All three bash regression tests pass after these changes.
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context