feat(player): quality ladder, trickplay scrub previews, Stats for nerds, androidtv header - #26
Merged
Merged
Conversation
…idtv header Add shared QualityLadder client (GET /playback/quality-ladder + fallback) and wire Auto/Original/rung menus into phone QualitySelector and TV HUD Video pane. Parse FileVersion.trickplay and show sprite-tile scrub previews on phone and TV. Rename playback stats entry to "Stats for nerds" with session/method/position. Align Android TV device platform header to androidtv (no hyphen). Co-authored-by: Jonah May <JonahMMay@users.noreply.github.com>
Ensure preferredQuality and playbackQualityIntent use toV3QualityPreference so high-bitrate ladder rungs replan correctly on TV. Co-authored-by: Jonah May <JonahMMay@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Extend commonTest coverage for QualityLadder parsing/fallback/options/ targets, Trickplay tile math, and PlaybackApi.getQualityLadder so :shared:koverVerify clears the 95% line floor. Co-authored-by: Jonah May <JonahMMay@users.noreply.github.com>
JonahMMay
marked this pull request as ready for review
August 28, 2026 00:50
Resolve conflicts keeping PR player features (quality ladder, trickplay scrub previews, stats for nerds, transcode APIs) while integrating main's tabletop pane height, marker bands, and recovery start params. Co-authored-by: Jonah May <JonahMMay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Android phone/TV lacked web/SmartTV-parity quality ladder selection and trickplay scrub previews. Stats labeling was inconsistent with SmartTV’s “Stats for nerds”. Android TV sent
android-tvso the server did not classify it as a TV for artwork rungs.Approach
QualityLadderclient; phone + TV HUD quality pickers; session restart via V3 preference + settings storeTrickplayInfo+ tile resolver; phone progress bar + TV scrub overlay via Coil cropandroidtvTesting
AI Disclosure
Checklist