Skip to content

Raise coverage gate to 95% #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonahMMay merged 2 commits into from
Jul 27, 2026
Merged

Raise coverage gate to 95% #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
855f9c6
Improve catalog coverage tests
cursoragent Jul 27, 2026
69044d9
ci: raise coverage gate to 95%
cursoragent Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
cancel-in-progress: true

env:
COVER_MIN: "90"
COVER_MIN: "95"

jobs:
lint:
Expand Down
43 changes: 23 additions & 20 deletions catalog/catalog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import (

func TestBuildPackageFromRelease_MinimalManifestAndAssets(t *testing.T) {
source := &SourceManifest{
PluginId: "prairie.tmdb",
Version: "1.2.3",
PluginId: "prairie.tmdb",
Version: "1.2.3",
PrairieApiVersion: "v1",
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Capabilities: []*pluginv1.CapabilityDescriptor{
{
Type: "metadata_provider.v1",
Expand Down Expand Up @@ -60,10 +60,10 @@ func TestBuildPackageFromRelease_MinimalManifestAndAssets(t *testing.T) {

func TestBuildPackageFromRelease_TagWinsOverManifestVersion(t *testing.T) {
source := &SourceManifest{
PluginId: "prairie.tmdb",
Version: "1.2.2",
PluginId: "prairie.tmdb",
Version: "1.2.2",
PrairieApiVersion: "v1",
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Capabilities: []*pluginv1.CapabilityDescriptor{
{Type: "metadata_provider.v1", Id: "tmdb"},
},
Expand All @@ -87,8 +87,8 @@ func TestBuildPackageFromRelease_TagWinsOverManifestVersion(t *testing.T) {

func TestBuildPackageFromRelease_RequiresCompletePresentation(t *testing.T) {
source := &SourceManifest{
PluginId: "prairie.tmdb",
Version: "1.2.3",
PluginId: "prairie.tmdb",
Version: "1.2.3",
PrairieApiVersion: "v1",
Capabilities: []*pluginv1.CapabilityDescriptor{
{Type: "metadata_provider.v1", Id: "tmdb"},
Expand Down Expand Up @@ -235,15 +235,15 @@ func TestUpsertPackage_ReplacesExistingPluginAndSorts(t *testing.T) {
Plugins: []CatalogPackage{
{
Manifest: &pluginv1.PluginManifest{
PluginId: "prairie.tvdb",
Version: "1.0.0",
PluginId: "prairie.tvdb",
Version: "1.0.0",
PrairieApiVersion: "v1",
},
},
{
Manifest: &pluginv1.PluginManifest{
PluginId: "prairie.tmdb",
Version: "1.0.0",
PluginId: "prairie.tmdb",
Version: "1.0.0",
PrairieApiVersion: "v1",
},
},
Expand All @@ -252,8 +252,8 @@ func TestUpsertPackage_ReplacesExistingPluginAndSorts(t *testing.T) {

updated := CatalogPackage{
Manifest: &pluginv1.PluginManifest{
PluginId: "prairie.tmdb",
Version: "1.2.3",
PluginId: "prairie.tmdb",
Version: "1.2.3",
PrairieApiVersion: "v1",
},
RepoURL: "https://github.com/prairie-server/prairie-plugin-metadata-tmdb",
Expand Down Expand Up @@ -282,8 +282,11 @@ func TestDecodeSourceManifestInvalidJSON(t *testing.T) {
}

func TestBuildPackageFromRelease_ErrorPaths(t *testing.T) {
const repo = "prairie-server/prairie-plugin-metadata-tmdb"

valid := &SourceManifest{
PluginId: "prairie.tmdb",
Version: "1.0.0",
PrairieApiVersion: "v1",
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Capabilities: []*pluginv1.CapabilityDescriptor{
Expand All @@ -307,16 +310,16 @@ func TestBuildPackageFromRelease_ErrorPaths(t *testing.T) {
if _, err := BuildPackageFromRelease("org/repo", &SourceManifest{PluginId: "x", PrairieApiVersion: "v1"}, Release{}); err == nil {
t.Fatal("expected capabilities required")
}
if _, err := BuildPackageFromRelease("org/repo", valid, Release{TagName: " "}); err == nil {
if _, err := BuildPackageFromRelease(repo, valid, Release{TagName: " "}); err == nil {
t.Fatal("expected tag_name required")
}
if _, err := BuildPackageFromRelease("org/repo", valid, Release{
if _, err := BuildPackageFromRelease(repo, valid, Release{
TagName: "v1.0.0",
Assets: []Asset{{Name: "plugin-linux-amd64", BrowserDownloadURL: "https://example.invalid/bin"}},
}); err == nil {
t.Fatal("expected missing checksums.txt")
}
if _, err := BuildPackageFromRelease("org/repo", valid, Release{
if _, err := BuildPackageFromRelease(repo, valid, Release{
TagName: "v1.0.0",
Assets: []Asset{{Name: "checksums.txt", BrowserDownloadURL: "https://example.invalid/c"}},
}); err == nil {
Expand All @@ -325,19 +328,19 @@ func TestBuildPackageFromRelease_ErrorPaths(t *testing.T) {

badCap := &SourceManifest{
PluginId: "prairie.tmdb",
Version: "1.0.0",
PrairieApiVersion: "v1",
Presentation: catalogTestPresentation("https://github.com/prairie-server/prairie-plugin-metadata-tmdb"),
Capabilities: []*pluginv1.CapabilityDescriptor{
{Type: "", Id: "tmdb"},
},
}
if _, err := BuildPackageFromRelease("org/repo", badCap, Release{TagName: "v1.0.0", Assets: assets}); err == nil {
if _, err := BuildPackageFromRelease(repo, badCap, Release{TagName: "v1.0.0", Assets: assets}); err == nil {
t.Fatal("expected capability type/id required")
}

valid.Version = "1.0.0"
// Malformed plugin asset names are skipped; checksums still present with one good binary.
pkg, err := BuildPackageFromRelease("prairie-server/prairie-plugin-metadata-tmdb", valid, Release{
pkg, err := BuildPackageFromRelease(repo, valid, Release{
TagName: "v1.0.0",
Assets: []Asset{
{Name: "plugin-bad", BrowserDownloadURL: "https://example.invalid/bad"},
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
# Fail if total statement coverage is below COVER_MIN (percent).
set -euo pipefail
COVER_MIN="${COVER_MIN:-90}"
COVER_MIN="${COVER_MIN:-95}"
PROFILE="${1:-coverage.out}"
if [[ ! -f "$PROFILE" ]]; then
echo "coverage profile missing: $PROFILE" >&2
Expand Down