Fix Windows supervisor replacement launch lock - #1327
Open
jonaowen wants to merge 1 commit into
Open
Conversation
jonaowen
force-pushed
the
fix/1286-windows-supervisor-lock
branch
from
August 13, 2026 03:58
76133ca to
a5ddf83
Compare
Author
|
Rebased cleanly onto current main |
jonaowen
force-pushed
the
fix/1286-windows-supervisor-lock
branch
from
August 13, 2026 08:44
a5ddf83 to
a62ed57
Compare
Author
|
Rebased onto current main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run check: green (Biome, tsgo, installer render, browser smoke)The patch does not change daemon wire/schema/protocol behavior. It preserves the existing socket hash and stale-lock algorithm; PID-reuse/token/ABA hardening is separate scope.
Fixes #1286.
Note
Fix Windows supervisor replacement launch lock in
AgentDaemonlaunchReplacementSupervisorfromdirname(supervisorSocketPath)to a global registry directory fromdefaultDaemonSupervisorRegistryDir(), fixing failures whensupervisorSocketPathis a Windows named-pipe path with no valid filesystem directory.0o700before use and treatsEPERMon rename (when the destination already exists) as equivalent to a pre-existing lock rather than throwing.defaultDaemonSupervisorRegistryDirfrom daemon-supervisor-ownership.ts so it can be imported by the daemon mode module.Macroscope summarized a62ed57.