Skip to content

fix(coding-agent): isolate invalid provider registrations - #1341

Open
mrrobotke wants to merge 1 commit into
PrimeIntellect-ai:mainfrom
mrrobotke:fix/1230-isolate-provider-registration
Open

fix(coding-agent): isolate invalid provider registrations#1341
mrrobotke wants to merge 1 commit into
PrimeIntellect-ai:mainfrom
mrrobotke:fix/1230-isolate-provider-registration

Conversation

@mrrobotke

@mrrobotke mrrobotke commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • treat failed extension provider registrations as non-fatal warnings
  • keep valid providers available when another extension has no resolvable credential
  • add focused regression coverage for mixed unavailable and valid providers

Behavior

An invalid provider is skipped with a diagnostic that identifies its extension and validation error. Other provider registrations continue loading, while selecting the skipped provider still follows the existing unavailable-provider path.

Validation

  • npx tsx ../../node_modules/vitest/dist/cli.js --run test/agent-session-services.test.ts test/suite/regressions/1230-provider-registration-isolation.test.ts
  • npm run check

Fixes #1230

Note

Isolate failed provider registrations in coding agent so valid providers still load

Previously, a single extension with an unavailable provider credential could block other providers from loading. Now, failed provider registrations in createAgentSessionServices are caught individually and reported as warnings ("Skipped provider from extension...") instead of errors, leaving valid providers unaffected. A regression test in 1230-provider-registration-isolation.test.ts verifies that a missing-credential provider is skipped while a valid provider registers successfully.

Macroscope summarized 52add7f.

Treat invalid extension provider registrations as non-fatal so one unavailable
credential cannot block unrelated providers.

Fixes PrimeIntellect-ai#1230

@jonaowen jonaowen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registration loop already isolates each extension provider structurally; changing a rejected provider registration from a process-fatal runtime diagnostic to a warning completes that isolation. The regression proves the invalid model is absent, a later valid provider remains registered, and no fatal diagnostic survives. Other extension load errors remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prime-agent: one provider with missing apiKey blocks ALL providers at extension load

2 participants