fix(coding-agent): isolate invalid provider registrations - #1341
Open
mrrobotke wants to merge 1 commit into
Open
fix(coding-agent): isolate invalid provider registrations#1341mrrobotke wants to merge 1 commit into
mrrobotke wants to merge 1 commit into
Conversation
Treat invalid extension provider registrations as non-fatal so one unavailable credential cannot block unrelated providers. Fixes PrimeIntellect-ai#1230
jonaowen
approved these changes
Aug 13, 2026
jonaowen
left a comment
There was a problem hiding this comment.
The registration loop already isolates each extension provider structurally; changing a rejected provider registration from a process-fatal runtime diagnostic to a warning completes that isolation. The regression proves the invalid model is absent, a later valid provider remains registered, and no fatal diagnostic survives. Other extension load errors remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
An invalid provider is skipped with a diagnostic that identifies its extension and validation error. Other provider registrations continue loading, while selecting the skipped provider still follows the existing unavailable-provider path.
Validation
npx tsx ../../node_modules/vitest/dist/cli.js --run test/agent-session-services.test.ts test/suite/regressions/1230-provider-registration-isolation.test.tsnpm run checkFixes #1230
Note
Isolate failed provider registrations in coding agent so valid providers still load
Previously, a single extension with an unavailable provider credential could block other providers from loading. Now, failed provider registrations in
createAgentSessionServicesare caught individually and reported as warnings ("Skipped provider from extension...") instead of errors, leaving valid providers unaffected. A regression test in 1230-provider-registration-isolation.test.ts verifies that a missing-credential provider is skipped while a valid provider registers successfully.Macroscope summarized 52add7f.