Skip to content

Bedrock support, add blockVariantsByStateId map#23

Open
extremeheat wants to merge 13 commits into
PrismarineJS:masterfrom
extremeheat:bedrockModels
Open

Bedrock support, add blockVariantsByStateId map#23
extremeheat wants to merge 13 commits into
PrismarineJS:masterfrom
extremeheat:bedrockModels

Conversation

@extremeheat

@extremeheat extremeheat commented Jan 10, 2023

Copy link
Copy Markdown
Member
  • Add bedrock support
    • for now assets are just mapped to pc data
    • currently only testing bedrock 1.19.1, can add other versions later after updates to mc-data
  • Implement blockVariantsByStateId from prismarine-viewer with bedrock handling inside mc-assets, this can be useful outside of prismarine-viewer

needs PrismarineJS/node-minecraft-data#257 merge & release

@extremeheat extremeheat marked this pull request as draft January 10, 2023 03:21
@rom1504

rom1504 commented Jan 21, 2023

Copy link
Copy Markdown
Member

failing

@rom1504

rom1504 commented Mar 4, 2023

Copy link
Copy Markdown
Member

what is the status here

@extremeheat

Copy link
Copy Markdown
Member Author

Blocked by PrismarineJS/node-minecraft-data#257

@socket-security

socket-security Bot commented Mar 25, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@extremeheat extremeheat marked this pull request as ready for review March 25, 2023 18:22
@rom1504

rom1504 commented May 28, 2023

Copy link
Copy Markdown
Member

@extremeheat do you think this is ready ?

@rom1504

rom1504 commented Nov 5, 2023

Copy link
Copy Markdown
Member

@extremeheat what do you think of this PR ?

@socket-security

socket-security Bot commented Jun 25, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/mocha@9.2.2 environment, eval, filesystem Transitive: shell +79 7.02 MB juergba
npm/prismarine-block@1.17.1 Transitive: environment, eval, filesystem, shell +28 232 MB rom1504
npm/prismarine-registry@1.7.0 Transitive: environment, eval +17 232 MB rom1504

View full report↗︎

@extremeheat

Copy link
Copy Markdown
Member Author

Yeah should be mergable, I fixed the conflicts.

@rom1504

rom1504 commented Nov 27, 2024

Copy link
Copy Markdown
Member

This needs resolving one more time sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants