Isolate repository validation from generated worktrees - #91
Merged
ProGraMajster merged 1 commit intoAug 20, 2026
Merged
Conversation
- centralize repository source traversal rules - exclude generated artifacts and nested worktrees from repository validation - preserve detection of real source-tree inconsistencies - harden root/path handling across Windows and CI - add regression coverage for generated and nested checkout content
ProGraMajster
marked this pull request as ready for review
August 20, 2026 16:06
ProGraMajster
deleted the
codex/issue-83-repository-validation-isolation
branch
August 20, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository-level validation now distinguishes tracked source files from generated artifacts and nested worktrees, eliminating false positives without hiding real source-tree inconsistencies.
Root cause
ReleaseVersionConsistencyTestspreviously scanned the filesystem recursively and could discover projects insideartifacts/, including complete nested worktrees with historical package versions.Solution
git ls-fileswhen Git metadata is available.gitdirectory or worktree fileRegression coverage
Coverage includes:
artifactscontent and complete nested worktreesbinandobj.gitdirectories and worktree filesArtifactsDocumentation,BinaryTools, andObjectModelValidation
dotnet restore .\ModernFormsNext.slnx: passedRepositoryFileEnumeratorTests: 28/28 passedReleaseVersionConsistencyTests: 5/5 passed with three existing nested worktrees underartifacts/git diff --check: passedCloses #83