Revert "fix: filter not wanted plugins changes"

[raven-wing]

Reverts #361

Summary by CodeRabbit

• Breaking Changes

  • Plugin base class is no longer directly importable from the main package.

• Bug Fixes

  • Fixed cross-origin resource sharing for plugin static assets.

• Chores

  • Updated plugin discovery mechanism to use an external service.
  • Adjusted framework dependency version.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4fcf93d2-c10d-4990-9ca7-c46543830ebc

📥 Commits

Reviewing files that changed from the base of the PR and between 265c330 and d24e2b4.

⛔ Files ignored due to path filters (1)

• poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

• goodmap/__init__.py
• goodmap/goodmap.py
• goodmap/plugin.py
• pyproject.toml
• tests/unit_tests/test_goodmap.py

---

📝 Walkthrough

Walkthrough

GoodmapPluginBase is removed from goodmap/plugin.py and its re-export from goodmap/__init__.py. Plugin entry-point discovery in goodmap.py switches from goodmap.plugins to platzky.plugins, and shortcode collection is replaced by delegating to app.shortcodes directly. The platzky dependency is downgraded to 2.0.0a2, and a new CORS header test is added.

Changes

Plugin and shortcode delegation to platzky

Layer / File(s)	Summary
Remove GoodmapPluginBase and its export goodmap/__init__.py, goodmap/plugin.py	Deletes the GoodmapPluginBase class and removes its import and __all__ re-export from the package initializer.
Switch entry-point group and shortcode wiring goodmap/goodmap.py	Changes plugin static-resource entry-point discovery from goodmap.plugins to platzky.plugins, drops ContentTransformerPluginBase/Shortcode imports, and replaces the app.loaded_plugins shortcode-collection loop with shortcodes=app.shortcodes passed directly into core_pages(...).
Dependency pin and CORS test pyproject.toml, tests/unit_tests/test_goodmap.py	Downgrades the platzky pin from 2.0.0a3 to 2.0.0a2; adds test_plugin_blueprint_sets_cors_header asserting Access-Control-Allow-Origin: * on plugin blueprint static responses.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Problematy/goodmap#333: Also modifies the platzky dependency version in pyproject.toml and adjusts plugin discovery logic.
• Problematy/goodmap#361: Directly modifies the same goodmap/goodmap.py shortcode-assembly and core_pages wiring that this PR replaces.

Poem

🐇 Hop hop, the plugins shed their skin,
No more GoodmapPluginBase within!
platzky.plugins now leads the way,
app.shortcodes handles the fray.
CORS stars shine on static files — hooray! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-361-goodmap_plugin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: d24e2b4

📊 E2E Stress Test Performance

✅ Status: PASSED (11363.56ms max < 25000ms limit)

Metric	Value
Average Time	10351.87ms
Minimum Time	9573.56ms
Maximum Time	11363.56ms
Completed Runs	5/5
Avg Markers Loaded	71

📈 Individual Run Times

Run	Time (ms)	Markers
Run 1	9969.52ms	71
Run 2	10023.48ms	71
Run 3	9573.56ms	71
Run 4	10829.24ms	71
Run 5	11363.56ms	71