You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks like a good security improvement overall. I like replacing Access-Control-Allow-Origin: * with an allowlist, and the AI key QR token also makes sense.
One thing I want fixed before merging: in supabase/functions/app-usage-event/index.ts, jsonResponse() calls corsHeaders(new Request('')) instead of using the real incoming request. That looks unsafe/suspicious and may break in Deno or return the wrong CORS headers.
Can you change it so jsonResponse receives the actual req, for example jsonResponse(req, body, status), and then all responses use corsHeaders(req)?
After that I think this should be safe to merge, assuming CORS_ALLOWED_ORIGINS is set to include the real ARVIO web domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces permissive wildcard CORS handling with an allowlist-based origin validation approach.
Previously, responses returned:
Access-Control-Allow-Origin: *This allowed requests from arbitrary browser origins.
The new implementation validates the incoming
Originheader against an environment-configured allowlist and only echoes approved origins.Changes Made
Replaced wildcard
Access-Control-Allow-Origin: *Added request-aware
corsHeaders(req)helperAdded environment-driven allowlist support via:
CORS_ALLOWED_ORIGINSDefault allowed origins:
https://auth.arvio.tvhttps://arvio.tvSecurity Impact
This reduces unintended cross-origin access exposure and aligns the edge-function CORS policy with least-privilege principles.
Disallowed origins no longer receive permissive CORS access headers.
Validation
Manually tested:
Verified that:
Deployment Notes
Configure allowed origins via: