Skip to content

fix(release): let a recovery dispatch actually reach the build #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MotherSphere merged 1 commit into from
Aug 27, 2026
Merged

fix(release): let a recovery dispatch actually reach the build #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ jobs:
build:
name: Build ${{ matrix.asset }}
needs: target
# Explicit, because a SKIPPED job propagates transitively: `target` runs on
# a dispatch thanks to its own status-function `if:`, but that does not
# clear the skip inherited from `release-please` for the jobs after it.
# Without this, a recovery dispatch resolves the tag and then silently
# builds nothing - which is exactly what the first v0.10.0 dispatch did.
if: ${{ needs.target.result == 'success' }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -229,6 +235,9 @@ jobs:
sign:
name: Sign release assets
needs: [target, build]
# Every dependency named explicitly. Guarding on `target` alone would let
# this run after a FAILED build and try to sign assets that do not exist.
if: ${{ needs.target.result == 'success' && needs.build.result == 'success' }}
runs-on: ubuntu-latest
env:
# Single source of truth for the four launcher assets. Declared once so the
Expand Down Expand Up @@ -321,6 +330,9 @@ jobs:
aur:
name: Publish colony-bin to AUR
needs: [target, sign]
# `sign` too: without it, a failed signing job would still bump the AUR
# package to a release that has no signatures.
if: ${{ needs.target.result == 'success' && needs.sign.result == 'success' }}
uses: ./.github/workflows/aur-publish.yml
with:
tag: ${{ needs.target.outputs.tag }}
Expand Down
Loading