fix(release): suppress the implicit success() that kept skipping the build - #74
Merged
Merged
Conversation
…build The second recovery dispatch still built nothing, with the same shape as the first: `target` succeeded and `build`, `sign` and `aur` skipped while the run reported success. Naming the dependencies explicitly in #73 was necessary but not sufficient. A job `if:` that contains no status-check function gets an implicit `success()` ANDed onto it, and that `success()` is evaluated over the whole ancestor graph rather than the direct `needs`. `release-please` is skipped on a dispatch, so the implicit `success()` was false and the job skipped no matter what the explicit condition said. The evidence was already in the file: `target` carries `!cancelled() && !failure()` and RAN despite the skipped ancestor, while `build` carried only `needs.target.result == 'success'` and skipped even though `target` had succeeded. Naming any status function suppresses the implicit one, so `!cancelled()` on each downstream job lets the explicit conditions govern. The explicit conditions from #73 are what make that safe to do: `!cancelled()` alone would run these jobs after a FAILED dependency, which is exactly what the per-dependency checks prevent. The two changes only work together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second recovery dispatch still built nothing, with the same shape as the
first:
targetsucceeded andbuild,signandaurskipped while the runreported success. Naming the dependencies explicitly in #73 was necessary but
not sufficient.
A job
if:that contains no status-check function gets an implicitsuccess()ANDed onto it, and that
success()is evaluated over the whole ancestor graphrather than the direct
needs.release-pleaseis skipped on a dispatch, sothe implicit
success()was false and the job skipped no matter what theexplicit condition said.
The evidence was already in the file:
targetcarries!cancelled() && !failure()and RAN despite the skipped ancestor, whilebuildcarried onlyneeds.target.result == 'success'and skipped even thoughtargethadsucceeded. Naming any status function suppresses the implicit one, so
!cancelled()on each downstream job lets the explicit conditions govern.The explicit conditions from #73 are what make that safe to do:
!cancelled()alone would run these jobs after a FAILED dependency, which is exactly what the
per-dependency checks prevent. The two changes only work together.