fix(release): upload with gh, not an action that insists on managing the draft - #75
Merged
Merged
Conversation
…the draft
With the job skips fixed, all four builds finally ran, compiled, and passed
their smoke test - and then every one failed uploading:
Found release v0.10.0 (with id=377998799)
Unexpected error fetching GitHub release for tag refs/heads/main:
HttpError: Resource not accessible by integration
- .../rest/releases/releases#update-a-release
softprops/action-gh-release does not just upload assets: it PATCHes the release
to manage the draft flag, and that update is refused against this draft. The
workflow grants contents: write and the repository default is write, so this is
the action's own insistence on owning a field it does not need to touch.
That insistence is also what published an empty v0.10.0 in front of users
earlier today: absent a `draft:` input it calls finalizeRelease() after
uploading, which sets draft:false. Adding `draft: true` stopped that, and now
the same code path 403s.
`gh release upload` only ever adds assets. It cannot publish a release, so the
draft is safe by construction rather than by remembering a flag - and it is
exactly what the sign job has done successfully since v0.9.2, in this same
workflow, with this same token. The action leaves the release path entirely,
which also removes a third-party action holding write access to releases.
The draft assertion after the upload stays. It is now belt-and-braces rather
than load-bearing, and it costs one API call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the job skips fixed, all four builds finally ran, compiled, and passed
their smoke test - and then every one failed uploading:
softprops/action-gh-release does not just upload assets: it PATCHes the release
to manage the draft flag, and that update is refused against this draft. The
workflow grants contents: write and the repository default is write, so this is
the action's own insistence on owning a field it does not need to touch.
That insistence is also what published an empty v0.10.0 in front of users
earlier today: absent a
draft:input it calls finalizeRelease() afteruploading, which sets draft:false. Adding
draft: truestopped that, and nowthe same code path 403s.
gh release uploadonly ever adds assets. It cannot publish a release, so thedraft is safe by construction rather than by remembering a flag - and it is
exactly what the sign job has done successfully since v0.9.2, in this same
workflow, with this same token. The action leaves the release path entirely,
which also removes a third-party action holding write access to releases.
The draft assertion after the upload stays. It is now belt-and-braces rather
than load-bearing, and it costs one API call.