You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gavarela Grove is distributed under Apache 2.0, same as ProjectQ, so there shouldn't be any problems with that. Though, as I understand it, it should be mentioned somewhere in the code that it's based on Grove's source code.
I was thinking in adding a general purpose QAOA as well, and looking at the VQE proposal I have some questions I would like to discuss with you all.
where should the functions be located? it seems that "examples" is not the more apropriate location. Somewhere as libs/ looks better, what do you think? any other place?
I see that there is a function "expectation" in the VQE porposal that can be leveraged by the QAOA or any other custom algorithm. IMHO it is worth to make a specific function/class out of it to be used in any other place (without the need to import the full VQE). Of course if you are using the simulator you can leverage the eng.backend.get_expectation_value function, but for a real device we could leverage a function like this.
following the documentation style, IMHO It would be great if you can add some "how to use" to the code to be included in the documentation
I realized that you already have a QAOA in your repo that could be added to the general purpose in addition to VQE
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. 1 out of 2 committers have signed the CLA.
✅ Takishima ❌ gavarela You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think I should mention this is based on grove's pyQuil implementation of VQE:
https://github.com/rigetti/grove/blob/master/grove/pyvqe/vqe.py
Are there any licensing/copyrights issues?