Fix #522: PG does not ignore comments in _CoqProject file. - #879
Closed
Matafou wants to merge 1 commit into
Closed
Conversation
cpitclaudel
added a commit
that referenced
this pull request
Jul 31, 2026
This is an attempt to follow lib/coqProject_file.ml instead of doing our own parsing: - # starts a comment line; - Single quotes toggle quoting and get stripped; - `\` isn't an escape character, so `-arg "-w \"a b\""` (which we used to accept) now needs to be written `-arg "-w 'a b'"`. Fixes #113, #392, #522, #589. Closes #879.
cpitclaudel
added a commit
that referenced
this pull request
Jul 31, 2026
This is an attempt to follow `lib/coqProject_file.ml` instead of doing our own parsing: - `#` starts a comment line; - Single quotes toggle quoting and get stripped; - `\` isn't an escape character, so `-arg "-w \"a b\""` (which we used to accept) now needs to be written `-arg "-w 'a b'"`. Fixes #113, #392, #522, #589. Closes #879.
Contributor
Author
|
Susbsumed by #880. |
cpitclaudel
added a commit
that referenced
this pull request
Aug 1, 2026
This is an attempt to follow `lib/coqProject_file.ml` instead of doing our own parsing: - `#` starts a comment line; - Single quotes toggle quoting and get stripped; - `\` isn't an escape character, so `-arg "-w \"a b\""` (which we used to accept) now needs to be written `-arg "-w 'a b'"`. Fixes #113, #392, #522, #589. Closes #879.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Lines starting with
#are now ignored when reading a project file.