Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .console/log.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
## 2026-08-19 — pushed a red test, caught it one command later

Shipping the council fix for #521 I added five probe tests and pushed before
reading the result: one asserted `normalize_version("13.0.5+gitea-1.22.0")`
yields `"13.0.5"`. It does not — that helper strips a leading tool name
("codex-cli 0.117.0"), not a build suffix. My assertion was wrong, not the
code, and keeping the suffix is better anyway: "+gitea-1.22.0" tells an
operator which Gitea API generation their Forgejo speaks.

The lesson is ordering, not the assertion: the gate output and the push were in
one script, so the push did not wait on the result. Gate first, read, then
push.

## 2026-08-19 — council: a health probe must not be able to throw

The Forgejo row I added to `dependency_check` called `response.json()`
Expand Down
8 changes: 7 additions & 1 deletion tests/test_dependency_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,14 @@ def _probe(monkeypatch, response):


def test_board_status_reports_version_and_health(monkeypatch):
"""The full version string survives, gitea-compat suffix and all.

`normalize_version` strips a leading tool name ("codex-cli 0.117.0"), not a
build suffix — and the suffix is worth keeping: it is how an operator tells
which Gitea API generation their Forgejo speaks.
"""
assert _probe(monkeypatch, _Resp(200, {"version": "13.0.5+gitea-1.22.0"})) == (
"13.0.5",
"13.0.5+gitea-1.22.0",
True,
)

Expand Down
Loading