Skip to content

Fix install workflow repository context - #134

Merged
renecannao merged 1 commit into
masterfrom
agent/fix-install-script-release-context
Jul 27, 2026
Merged

Fix install workflow repository context#134
renecannao merged 1 commit into
masterfrom
agent/fix-install-script-release-context

Conversation

@renecannao

@renecannao renecannao commented Jul 27, 2026

Copy link
Copy Markdown

Summary

  • Pin the install-test workflow's gh release view command to ProxySQL/dbdeployer.
  • Prevent the version verification step from failing in its checkout-less runner.

Root cause

The workflow runs without actions/checkout, so GitHub CLI has no local repository context. The unqualified gh release view command therefore failed before comparing the installed version.

Validation

  • Verified the previously failing command from a directory without Git metadata.
  • Verified gh release view --repo ProxySQL/dbdeployer --json tagName --jq '.tagName' succeeds and returns v2.3.0.
  • Parsed .github/workflows/install_script_test.yml successfully.
  • git diff --check passes.

Summary by CodeRabbit

  • Bug Fixes
    • Improved installation verification by checking the installed version against the published release version.
    • Retained clear version reporting and failure detection when the versions do not match.

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a22d6415-a5f3-4fc5-87df-cc012bda74d0

📥 Commits

Reviewing files that changed from the base of the PR and between eae033e and c8c412f.

📒 Files selected for processing (1)
  • .github/workflows/install_script_test.yml

📝 Walkthrough

Walkthrough

The install script test workflow now derives EXPECTED_VERSION from the published GitHub release tag, stripping a leading v; the existing installed-versus-expected comparison remains unchanged.

Changes

Install version verification

Layer / File(s) Summary
Published release version lookup
.github/workflows/install_script_test.yml
The workflow uses gh release view to obtain tagName, removes a leading v, and compares the result with the installed version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A bunny checks the version line,
From release tags crisp and fine.
“v” hops off, the numbers stay,
Installed and expected match today.
~(=^・ω・^=)~

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the workflow fix for using the correct repository context during release version checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-install-script-release-context

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renecannao
renecannao marked this pull request as ready for review July 27, 2026 22:35
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@renecannao
renecannao merged commit 4d9f5b5 into master Jul 27, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant