Skip to content

The default prompt is mysql or MariaDB depending of the flavor - #138

Merged
renecannao merged 1 commit into
ProxySQL:masterfrom
lefred:mariadb-default-prompt
Jul 31, 2026
Merged

The default prompt is mysql or MariaDB depending of the flavor#138
renecannao merged 1 commit into
ProxySQL:masterfrom
lefred:mariadb-default-prompt

Conversation

@lefred

@lefred lefred commented Jul 31, 2026

Copy link
Copy Markdown

For example, deploying a single instance with default settings

dbdeployer deploy single  13.1.

will give:

$ ./use
Welcome to the MariaDB monitor.  Commands end with ; or \g.
Your MariaDB connection id is 64
Server version: 13.1.0-MariaDB MariaDB Server

Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.

Help others discover MariaDB. Star it on GitHub: https://github.com/MariaDB/server

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

MariaDB [localhost:13100] {msandbox} ((none)) >

Summary by CodeRabbit

  • Bug Fixes
    • MariaDB sandboxes now default to the MariaDB prompt when no prompt is configured and flavor inclusion is disabled.
    • Other database flavors continue to use the mysql default prompt.

Signed-off-by: Frederic Descamps <lefred.descamps@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3735e1c1-a5d4-4351-b33d-ce808bc23cfd

📥 Commits

Reviewing files that changed from the base of the PR and between 373c2ad and c7f2d99.

📒 Files selected for processing (1)
  • sandbox/sandbox.go

📝 Walkthrough

Walkthrough

The sandbox default prompt now uses MariaDB for MariaDB sandboxes without flavor inclusion. Other flavors continue to use mysql.

Changes

MariaDB prompt behavior

Layer / File(s) Summary
Flavor-specific default prompt
sandbox/sandbox.go
The default prompt is MariaDB for MariaDB sandboxes and mysql for other flavors when no prompt is configured and flavor inclusion is disabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: renecannao

Poem

A rabbit checks the prompt with care,
MariaDB now waits there.
Other flavors keep mysql in sight,
A tiny change, precise and right.
Hop, hop—defaults align tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: the default prompt depends on the database flavor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renecannao

Copy link
Copy Markdown

Thank you @lefred !

@renecannao
renecannao merged commit 03b9079 into ProxySQL:master Jul 31, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants