Expose ProxySQL version as PROXYSQL_VERSION env var by renecannao · Pull Request #20 · ProxySQL/docker-images

renecannao · 2026-07-31T23:25:51Z

Summary

Adds ENV PROXYSQL_VERSION="${VERS}" to both the Debian and CentOS Dockerfiles so that derived images and runtime scripts can discover the installed ProxySQL version without parsing package metadata.

Changes

proxysql-images/proxysql-debian/Dockerfile: Added ENV PROXYSQL_VERSION
proxysql-images/proxysql-centos/Dockerfile: Added ENV PROXYSQL_VERSION
proxysql-images/test.sh: New test script that verifies:
1. The env var is set correctly at build time
2. The env var matches the installed proxysql --version output
3. The env var is inherited by derived images
proxysql-images/Makefile: Added test target

CI Workflows

.github/workflows/dockerfile-lint.yml: Runs hadolint recursively on all Dockerfiles
.github/workflows/shellcheck.yml: Runs shellcheck on all shell scripts
.github/workflows/proxysql-test.yml: Builds and tests proxysql images (debian + centos matrix), triggered on changes to proxysql-images/

Usage

# Run tests locally (defaults to latest release, debian)
make test

# Specify version and distro
make test VERS=2.7.3 DIST=centos

Closes #19

Add ENV PROXYSQL_VERSION to both Debian and CentOS Dockerfiles so that derived images and runtime scripts can discover the installed version without parsing package metadata. Includes a test script (test.sh) that verifies: - The env var is set correctly at build time - The env var matches the installed proxysql version - The env var is inherited by derived images Closes #19

coderabbitai · 2026-07-31T23:26:08Z

Warning

Review limit reached

@renecannao, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0befd1b3-15f2-4cc8-8bee-e1ff20843fe0

📥 Commits

Reviewing files that changed from the base of the PR and between f4dc27b and ff7b14f.

📒 Files selected for processing (4)

.github/workflows/dockerfile-lint.yml
.github/workflows/proxysql-test.yml
.github/workflows/shellcheck.yml
proxysql-images/test.sh

📝 Walkthrough

Walkthrough

The Docker images now expose PROXYSQL_VERSION from the VERS build argument. A Bash harness builds distribution-specific images, validates version reporting and inheritance, cleans up images, and reports failures. The Makefile provides a test target.

Changes

ProxySQL version validation

Layer / File(s)	Summary
Expose the ProxySQL version `proxysql-images/proxysql-centos/Dockerfile`, `proxysql-images/proxysql-debian/Dockerfile`	Both Dockerfiles set `PROXYSQL_VERSION` from the `VERS` build argument.
Build and validate images `proxysql-images/test.sh`, `proxysql-images/Makefile`	`test.sh` selects a version and distribution, builds the image, checks the environment and binary versions, verifies inheritance in a derived image, cleans up, and reports failures. The Makefile exposes this harness through the `test` target.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Poem

I’m a rabbit with a version to share,
PROXYSQL_VERSION now travels everywhere.
Images are tested, derived ones too,
Cleanup hops when the checks are through.
One small shell says what passed or failed.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The Dockerfiles set PROXYSQL_VERSION from VERS, which satisfies issue `#19` and supports version discovery in derived images.
Out of Scope Changes check	✅ Passed	The test harness and Makefile target directly support validation and execution of the requested environment variable change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: exposing the ProxySQL version through the PROXYSQL_VERSION environment variable.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch expose-proxysql-version-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@proxysql-images/test.sh`:
- Around line 15-18: Update the cleanup function and trap setup in cleanup() so
both IMAGE and DERIVED_IMAGE are removed on every exit. Define DERIVED_IMAGE
before installing the EXIT trap, then add its forced removal to cleanup();
remove or avoid relying on the separate normal-completion cleanup near the
derived-image command.
- Around line 6-9: Update the automatic version resolution in test.sh around
VERS and the GitHub releases API call to fail before docker build when the
request errors, times out, or returns an invalid response. Ensure the extracted
tag_name is present, non-empty, and a string, strip the leading v only after
validation, and reject any resulting empty version while preserving explicitly
supplied VERS values.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 71c2b405-d204-4172-b714-5560cdf8d2ee

📥 Commits

Reviewing files that changed from the base of the PR and between cd8fc9a and f4dc27b.

📒 Files selected for processing (4)

proxysql-images/Makefile
proxysql-images/proxysql-centos/Dockerfile
proxysql-images/proxysql-debian/Dockerfile
proxysql-images/test.sh

- dockerfile-lint.yml: runs hadolint recursively on all Dockerfiles - shellcheck.yml: runs shellcheck on all shell scripts - proxysql-test.yml: builds and tests proxysql images (debian + centos) triggered only on changes to proxysql-images/

…t threshold to error

…ed image in trap

coderabbitai Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread proxysql-images/test.sh

Comment thread proxysql-images/test.sh

renecannao added 5 commits August 1, 2026 01:36

Add GitHub Actions workflows for CI

a7f22f0

- dockerfile-lint.yml: runs hadolint recursively on all Dockerfiles - shellcheck.yml: runs shellcheck on all shell scripts - proxysql-test.yml: builds and tests proxysql images (debian + centos) triggered only on changes to proxysql-images/

Fix CI: use legacy docker build for derived image test, raise hadolin…

31d7450

…t threshold to error

Fix hadolint workflow: run via docker image, skip obsolete dirs

e0130ee

Fix hadolint: mount workspace volume so container can access files

43f96ab

Address CodeRabbit feedback: robust version resolution, cleanup deriv…

ff7b14f

…ed image in trap

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose ProxySQL version as PROXYSQL_VERSION env var - #20

Expose ProxySQL version as PROXYSQL_VERSION env var#20
renecannao wants to merge 6 commits into
mainfrom
expose-proxysql-version-env

renecannao commented Jul 31, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 31, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

renecannao commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

CI Workflows

Usage

Uh oh!

coderabbitai Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

renecannao commented Jul 31, 2026 •

edited

Loading

coderabbitai Bot commented Jul 31, 2026 •

edited

Loading