Skip to content

fix(ui): upgrade bundled jQuery to 3.7.1 for CVE compliance - #111

Merged
renecannao merged 2 commits into
masterfrom
fix/upgrade-jquery-3.7
Jul 27, 2026
Merged

fix(ui): upgrade bundled jQuery to 3.7.1 for CVE compliance#111
renecannao merged 2 commits into
masterfrom
fix/upgrade-jquery-3.7

Conversation

@renecannao

Copy link
Copy Markdown

Summary

  • Upgrades bundled resources/public/js/jquery.min.js from 1.11.3 → 3.7.1 (meets ≥ 3.5.0 scanner / customer requirement)
  • Upgrades jquery-ui.min.js from 1.11.4 → 1.13.3 so cluster drag/drop keeps working on jQuery 3.x
  • Adds TestBundledJQueryMeetsSecurityFloor so CI fails if jQuery regresses below 3.5.0

This is a focused CVE/security response for customers scanning UI static assets. Broader frontend modernization remains in #103.

Context

Customer report: Percona/ProxySQL packages still ship jQuery 1.11.3; fixed version required is ≥ 3.5.0. Confirmed on current master before this change.

Test plan

  • go test ./go/http/ -run 'TestBundledJQueryMeetsSecurityFloor|TestRenderHTMLYield' -v
  • Manual smoke: open /web/clusters, /web/cluster/<name> (drag/drop), cookie toggles (auto-refresh / anonymize)
  • Confirm jquery.min.js response header/banner shows jQuery v3.7.1

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@renecannao, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fed22022-561b-4907-9e1c-016b8ae115a4

📥 Commits

Reviewing files that changed from the base of the PR and between 0b79ec0 and 685a4a3.

⛔ Files ignored due to path filters (2)
  • resources/public/js/jquery-ui.min.js is excluded by !**/*.min.js
  • resources/public/js/jquery.min.js is excluded by !**/*.min.js
📒 Files selected for processing (1)
  • go/http/static_assets_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upgrade-jquery-3.7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

resources/public/js/jquery.min.js was still 1.11.3, below the common
scanner floor of 3.5.0. Bump to jQuery 3.7.1 and jQuery UI 1.13.3
(required for jQuery 3.x compatibility with cluster drag/drop).

Add a unit test that fails if the bundled jQuery header regresses
below 3.5.0.
@renecannao
renecannao force-pushed the fix/upgrade-jquery-3.7 branch from a4bac8c to 685a4a3 Compare July 27, 2026 15:46
@renecannao
renecannao merged commit b1ac4a2 into master Jul 27, 2026
17 checks passed
@renecannao
renecannao deleted the fix/upgrade-jquery-3.7 branch July 27, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant