fix(ui): upgrade bundled jQuery to 3.7.1 for CVE compliance - #111
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
resources/public/js/jquery.min.js was still 1.11.3, below the common scanner floor of 3.5.0. Bump to jQuery 3.7.1 and jQuery UI 1.13.3 (required for jQuery 3.x compatibility with cluster drag/drop). Add a unit test that fails if the bundled jQuery header regresses below 3.5.0.
a4bac8c to
685a4a3
Compare
Summary
resources/public/js/jquery.min.jsfrom 1.11.3 → 3.7.1 (meets ≥ 3.5.0 scanner / customer requirement)jquery-ui.min.jsfrom 1.11.4 → 1.13.3 so cluster drag/drop keeps working on jQuery 3.xTestBundledJQueryMeetsSecurityFloorso CI fails if jQuery regresses below 3.5.0This is a focused CVE/security response for customers scanning UI static assets. Broader frontend modernization remains in #103.
Context
Customer report: Percona/ProxySQL packages still ship jQuery 1.11.3; fixed version required is ≥ 3.5.0. Confirmed on current
masterbefore this change.Test plan
go test ./go/http/ -run 'TestBundledJQueryMeetsSecurityFloor|TestRenderHTMLYield' -v/web/clusters,/web/cluster/<name>(drag/drop), cookie toggles (auto-refresh / anonymize)jquery.min.jsresponse header/banner showsjQuery v3.7.1