Skip to content

fix: make orchestrator -version never print empty output (#109) - #112

Merged
renecannao merged 1 commit into
masterfrom
fix/issue-109-version-output
Jul 27, 2026
Merged

fix: make orchestrator -version never print empty output (#109)#112
renecannao merged 1 commit into
masterfrom
fix/issue-109-version-output

Conversation

@renecannao

Copy link
Copy Markdown

Summary

Fixes #109orchestrator -version printed nothing after a plain go build.

  • AppVersion / GitCommit are only set via -ldflags in release builds
  • Default to RELEASE_VERSION (4.30.0 (devel) when ldflags unset)
  • Do not print a blank GitCommit line
  • Fix script/build to set main.AppVersion + main.GitCommit (was using unused BuildDescribe)
  • Tests: default matches RELEASE_VERSION; version output never empty

Test plan

  • go test ./go/cmd/orchestrator/
  • go build -o bin/orchestrator go/cmd/orchestrator/main.go && ./bin/orchestrator -version4.30.0 (devel)
  • ldflags build prints injected version + commit
  • script/build → version + commit hash

Plain `go build` left AppVersion/GitCommit unset (only build.sh ldflags
filled them), so `-version` printed blank lines.

Default to RELEASE_VERSION (marked devel when unset), skip empty
GitCommit lines, align script/build ldflags with main.GitCommit, and
add tests so defaultAppVersion stays in sync with RELEASE_VERSION.
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@renecannao, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 326214f1-9020-43b1-a05b-0f8e8358a7bc

📥 Commits

Reviewing files that changed from the base of the PR and between b1ac4a2 and 3bdf666.

📒 Files selected for processing (3)
  • go/cmd/orchestrator/main.go
  • go/cmd/orchestrator/version_test.go
  • script/build
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-109-version-output

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@renecannao
renecannao merged commit 0bc318c into master Jul 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running the version command returns empty output

1 participant