Skip to content

Add raft/health Prometheus metrics (rebased #105) - #113

Merged
renecannao merged 8 commits into
masterfrom
fix/pr105-metrics-rebase
Jul 27, 2026
Merged

Add raft/health Prometheus metrics (rebased #105)#113
renecannao merged 8 commits into
masterfrom
fix/pr105-metrics-rebase

Conversation

@renecannao

Copy link
Copy Markdown

Summary

Rebased and lightly polished community PR #105 onto current master.

  • Health/ready/raft/discovery/recovery Prometheus metrics from @rfpronk
  • orchestrator_health_is_live now reflects recent health-check ticks (not always 1)
  • Help text notes raft gauges are 0 when raft is disabled
  • Comment on metrics-tick GetReplicationAnalysis cost

Closes / supersedes landing path for #105 once CI is green.

Test plan

  • go test ./go/metrics/
  • go build ./go/cmd/orchestrator
  • CI full suite

rfpronk and others added 8 commits July 27, 2026 19:20
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
…seconds

Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
Signed-off-by: Robin F. Pronk <robin.pronk@nedap.com>
- health_is_live uses recent health-check freshness instead of always-1
- Clarify raft_is_healthy help when raft is disabled
- Document GetReplicationAnalysis cost on the metrics tick

Rebased on current master for CI.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@renecannao, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 234a1fc3-640f-48ba-bd37-2244c471e875

📥 Commits

Reviewing files that changed from the base of the PR and between 0bc318c and b9ca570.

📒 Files selected for processing (3)
  • go/logic/orchestrator.go
  • go/logic/topology_recovery.go
  • go/metrics/prometheus.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr105-metrics-rebase

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renecannao
renecannao merged commit 219be2b into master Jul 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants