Add update_fields option to write word/settings.xml - #48
Open
ajay20015 wants to merge 3 commits into
Open
Conversation
relpath after walkdir returns native separators, so the test's
hardcoded forward-slash keys ("word/settings.xml", etc.) never
matched on Windows.
ajay20015
force-pushed
the
aja/settings-xml-support
branch
from
July 26, 2026 13:17
f53e3d4 to
fc22631
Compare
ajay20015
marked this pull request as ready for review
July 26, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
update_fields::Boolfield toDocument(defaultfalse). Whentrue,savewritesword/settings.xmlcontaining<w:updateFields w:val="true"/>, so Word recomputes every field (e.g. a hand-built TOC'sPAGEREFpage numbers) the first time the document is opened.Fixes #47 .
Wired the same way
styles.xmlalready is: aSettingsRelsingleton throughresolve_rel!, added togather_relsonly whenupdate_fieldsis set, plus acontent_typesoverride forapplication/vnd.openxmlformats-officedocument.wordprocessingml.settings+xml.Adding the field removed
Document's implicit 2-arg constructor (Document(body, styles)), which one existing test used directly. Added that constructor back explicitly, defaultingupdate_fieldstofalse.