Skip to content

fix: ttl for failed.queue in connection in email and push service #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harjibbolar26 merged 1 commit into from
Nov 15, 2025
Merged

fix: ttl for failed.queue in connection in email and push service #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion email_service/src/email/email.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,12 @@ export class EmailService implements OnModuleInit, OnModuleDestroy {
'x-message-ttl': 86400000, // 24 hours
},
});
await channel.assertQueue('failed.queue', { durable: true });
await channel.assertQueue('failed.queue', {
durable: true,
arguments: {
'x-message-ttl': 86400000, // 24 hours
},
});

console.log('📬 Queues asserted');
const queueInfo = await channel.checkQueue('email.queue');
Expand Down
10 changes: 6 additions & 4 deletions push-service/src/push/push.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,12 @@ export class PushService implements OnModuleInit, OnModuleDestroy {
'x-message-ttl': 86400000,
},
});
await channel.assertQueue('failed.queue', { durable: true });
await channel.assertQueue('failed.queue', {
durable: true,
arguments: {
'x-message-ttl': 86400000, // 24 hours
},
});

const queueInfo = await channel.checkQueue('push.queue');
console.log('📊 Queue Status BEFORE consuming:');
Expand Down Expand Up @@ -196,7 +201,6 @@ export class PushService implements OnModuleInit, OnModuleDestroy {
data: message.metadata,
});


await this.updateStatus(
correlationId,
NotificationStatus.DELIVERED,
Expand All @@ -211,7 +215,6 @@ export class PushService implements OnModuleInit, OnModuleDestroy {

channel.ack(msg);
this.retryAttempts.delete(correlationId);

} catch (error: any) {
const attempts = this.retryAttempts.get(correlationId) || 0;

Expand Down Expand Up @@ -331,7 +334,6 @@ export class PushService implements OnModuleInit, OnModuleDestroy {
JSON.stringify(updatedStatus),
);


const apiGatewayUrl =
process.env.API_GATEWAY_URL || 'http://localhost:3000';

Expand Down