Skip to content

test(agent-core): give the sweep-resilience wait the full test budget #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elkaix merged 1 commit into from
Aug 22, 2026
Merged

test(agent-core): give the sweep-resilience wait the full test budget #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/agent-core/test/mcp/oauth-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,12 @@ async function deliverCallback(flow: BeginAuthorizationResult): Promise<void> {
await response.text();
}

async function waitFor(condition: () => boolean, description: string): Promise<void> {
const deadline = Date.now() + 5000;
async function waitFor(
condition: () => boolean,
description: string,
timeoutMs = 5000,
): Promise<void> {
const deadline = Date.now() + timeoutMs;
while (!condition()) {
if (Date.now() > deadline) throw new Error(`timed out waiting for ${description}`);
await new Promise((resolve) => setTimeout(resolve, 10));
Expand Down Expand Up @@ -618,9 +622,13 @@ describe('McpOAuthService sweepProactiveRefresh resilience', () => {
await writeFile(join(fixture.storeDir, 'corrupt-meta.json'), '{not json', 'utf-8');

expect(() => fixture.service.sweepProactiveRefresh()).not.toThrow();
// The immediate refresh spans two localhost HTTP round-trips plus token
// writes; on a loaded CI runner that can outlast the default 5s budget
// while staying well inside this test's own 15s timeout.
await waitFor(
() => authServer.counts.refresh === 1,
'the swept credential to refresh immediately',
12_000,
);
}, 15000);
});
Expand Down
Loading