Skip to content

fix: make desktop release shell explicit #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elkaix merged 2 commits into from
Aug 25, 2026
Merged

fix: make desktop release shell explicit #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
019e4d0
fix: make desktop release shell explicit
elkaix Aug 25, 2026
a3e0dea
test: scope desktop shell checks by platform
elkaix Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ jobs:
- run: pnpm install --frozen-lockfile

- name: Configure desktop release
shell: bash
Comment thread
coderabbitai[bot] marked this conversation as resolved.
env:
DESKTOP_CHANNEL: ${{ needs.prepare.outputs.channel }}
DESKTOP_VERSION: ${{ needs.prepare.outputs.version }}
Expand Down Expand Up @@ -355,6 +356,7 @@ jobs:
- run: pnpm install --frozen-lockfile

- name: Configure desktop release
shell: bash
env:
DESKTOP_CHANNEL: ${{ needs.prepare.outputs.channel }}
DESKTOP_VERSION: ${{ needs.prepare.outputs.version }}
Expand Down
8 changes: 8 additions & 0 deletions scripts/release/release-workflows.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ import test from 'node:test';
const root = resolve(import.meta.dirname, '../..');
const read = (path) => readFileSync(resolve(root, path), 'utf8');

void test('desktop releases configure both platforms with Bash', () => {
const workflow = read('.github/workflows/desktop-release.yml');
const configuredWithBash = /^ - name: Configure desktop release\n shell: bash$/mu;
const windowsStart = workflow.indexOf('\n windows:');
assert.match(workflow.slice(workflow.indexOf('\n mac:'), windowsStart), configuredWithBash);
assert.match(workflow.slice(windowsStart, workflow.indexOf('\n publish:', windowsStart)), configuredWithBash);
});

void test('release workflow uses full push-boundary lane signals and isolated jobs', () => {
const workflow = read('.github/workflows/release.yml');
const desktopJob = workflow.slice(
Expand Down
Loading