No std ThreadId#6056
Open
Person-93 wants to merge 7 commits into
Open
Conversation
davidhewitt
reviewed
May 22, 2026
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, one comment on the FFI definition (see below).
Do you expect that the test suite (which does a lot of thread spawning) will need to change?
Contributor
Author
I don't think it will need to change, but it might be worth enabling it for wasm build and pulling in one of the wasm threading crates as a dev dependency. |
davidhewitt
reviewed
Jun 2, 2026
22f6ce6 to
2f2eb80
Compare
2f2eb80 to
513cc78
Compare
davidhewitt
reviewed
Jun 9, 2026
Merging this PR will improve performance by 12.96%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
Contributor
|
@codspeedbot explain why this is faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement
ThreadIdusingPyThread_get_thread_ident. This makes is usable inno_stdcontext.