Add selectable Fish/Zellij shell and session backends - #1
Draft
Pyrobrick wants to merge 8 commits into
Draft
Conversation
…default - Pin fish to 3.7.1-r0 (latest in Alpine 3.21) - Pin zellij to 0.40.0-r0 (latest in Alpine 3.21) - Remove hardcoded sed that changes /bin/sh to /usr/bin/fish globally This allows startup scripts to handle shell selection via config The shell selection should be determined at runtime by the startup scripts based on the 'shell' and legacy 'zsh' configuration options, not hardcoded in the image.
Preserve legacy defaults unless the new selectors are explicitly set, keep the root account POSIX-compatible for remote commands, and dispatch only interactive sessions through shell/backend wrappers. Add regression coverage, shell/YAML validation, and updated documentation.
Use Alpine 3.24 package versions, pin the checkout action, test remote command quoting and exit statuses, make the root Bash rewrite directly testable, and clarify root/Mosh command-mode behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell(fish,zsh, orbash) andsession_backend(zellijortmux) selectors.Compatibility behavior
zshoption and tmux.ssh host "ha core info"run through Bash without entering a multiplexer.Validation
Local checks completed:
ssh/tests/test-terminal-backends.shThe dedicated regression job runs alongside the reusable app CI. The reusable workflow already lints the app and builds both configured architectures (
amd64andaarch64).Remaining integration checks
This remains a draft until those integration checks pass.