docs(changelog): correct 1.6.0 peering framing#166
Merged
Conversation
…ded from config hash) The prepare-1.6.0 entry implied the previewchain.json change makes seeds reject each other at the handshake. featureTriggers (and checkpoints) are excluded from getChainConfigHash(), so the peering hash is unchanged and 1.6.0 peers normally with 1.5.x. The real requirement is consensus-level: all block-producing nodes on 1.6.0 before height 70000. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prepare Core 1.6.0changelog entry said thepreviewchain.jsonchange is a "chain-configuration change, so every preview seed must move to 1.6.0 as a coordinated update" — which reads as a peering flag-day.That's inaccurate.
BlockChain.computeChainConfigHash()removesfeatureTriggersandcheckpointsbefore hashing (CHAIN_CONFIG_HASH_EXCLUDED_FIELDS, BlockChain.java:58-60), and all 10 new activation heights live insidefeatureTriggers. So thechainConfigHashand genesis signature are byte-identical to v1.5.1 and the handshake compatibility check (Handshake.java:719-720) still passes — 1.6.0 peers normally with 1.5.x/1.4.x.The genuine requirement is at consensus, not peering: every block-producing node (seeds + minters) must be on 1.6.0 before height 70000 or it forks when the AT-v3/avatar rules activate. This corrects the wording accordingly.
🤖 Generated with Claude Code